Skip to content

Commit a4998c5

Browse files
authored
chore: Model.disableWarnings across codebase (#9360)
1 parent 3744d89 commit a4998c5

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

modules/aggregation-layers/src/common/aggregator/gpu-aggregator/webgl-bin-sorter.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,8 @@ void main() {
252252
isInstanced: false,
253253
vs,
254254
fs,
255-
topology: 'point-list'
255+
topology: 'point-list',
256+
disableWarnings: true
256257
});
257258
return model;
258259
}

modules/arcgis/src/commons.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,8 @@ void main(void) {
109109
pos: {size: 2, value: new Int8Array([-1, -1, 1, -1, -1, 1, -1, 1, 1, 1, 1, -1])}
110110
}
111111
}),
112-
vertexCount: 6
112+
vertexCount: 6,
113+
disableWarnings: true
113114
});
114115

115116
const fbo = device.createFramebuffer({

modules/extensions/src/data-filter/aggregator.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ export function getModel(
103103
vertexCount: 1,
104104
isInstanced: false,
105105
topology: 'point-list',
106+
disableWarnings: true,
106107
vs: AGGREGATE_VS,
107108
fs: AGGREGATE_FS,
108109
bufferLayout,

modules/extensions/src/data-filter/shader-module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ function getUniforms(opts?: DataFilterModuleProps | {}): Record<string, any> {
162162
filterEnabled = true,
163163
filterTransformSize = true,
164164
filterTransformColor = true,
165-
categoryBitMask = [0, 0, 0, 0]
165+
categoryBitMask
166166
} = opts;
167167
const filterSoftRange = opts.filterSoftRange || filterRange;
168168

@@ -184,7 +184,7 @@ function getUniforms(opts?: DataFilterModuleProps | {}): Record<string, any> {
184184
useSoftMargin: Boolean(opts.filterSoftRange),
185185
transformSize: filterEnabled && filterTransformSize,
186186
transformColor: filterEnabled && filterTransformColor,
187-
categoryBitMask
187+
...(categoryBitMask && {categoryBitMask})
188188
};
189189
}
190190

test/modules/mesh-layers/scenegraph-layer.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ test('ScenegraphLayer#tests', t => {
8989
geometry: new CubeGeometry(),
9090
vs,
9191
fs,
92-
modules: [project32]
92+
modules: [project32],
93+
disableWarnings: true
9394
})
9495
})
9596
]);

0 commit comments

Comments
 (0)