-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(mapbox-overlay) interleaved overlay using correct default parameters #9871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(mapbox-overlay) interleaved overlay using correct default parameters #9871
Conversation
| ...this._props, | ||
| gl, | ||
| parameters: {...getDefaultParameters(map, false), ...this._props.parameters}, | ||
| parameters: {...getDefaultParameters(map, true), ...this._props.parameters}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixpalmer you added this line in #9803 it does seem that it should be true?
|
Which issue is this resolving? I'm trying to reproduce |
https://openjs-foundation.slack.com/archives/C05JCDKHQUE/p1763426667707549 |
|
See this example: Interleaved mode draws jagged lines, whereas overlay mode seems to have anti-aliasing. Overlay mode (smooth):
Interleaved mode (jagged):
The issue also appears pretty clearly in the arc example you linked to here - that's the example where I first noticed it. If you switch between overlay & interleaved mode, you can see the anti-aliasing toggle. |
|
I attempted to test this fix myself and I found that it didn't seem to change the behavior here. But I realized here that just setting That's not to say that this change shouldn't land though. It does look like this prop probably was supposed to be set to |
Yes, this is the case (and always has been). So, just to confirm, setting antialias=true solves your issue? If so, I think we can close this without the change. I'd rather not make a change to this area unless @felixpalmer says otherwise (he recently did an audit of these parameters) or there was a regression. Feel free to open a doc PR adding a remark about this for interleaved users - deck shouldn't change Mapbox props, so antialiasing will need to be configured by users who want to use it. |


Summary
Testing
Codex Task