Fix: Make sizeBasis optional in IconLayer type definition #9883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9851
Background
The
sizeBasisproperty was added in #9736 with a default value of'height'but incorrectly marked as required in the TypeScript type definition, causing type errors when the property is omitted:Change List
sizeBasisas optional in_IconLayerProps<DataT>type definition to align with its default value and documentationWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io/usr/local/bin/node /usr/local/bin/node install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/127.0.6533.88/linux64/chrome-linux64.zip/usr/local/bin/node /usr/local/bin/node install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Note
Marks
IconLayerpropsizeBasisas optional to align with defaults and prevent TypeScript errors when omitted.Written by Cursor Bugbot for commit 1ae1c50. This will update automatically on new commits. Configure here.