Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 Updated url in open_autojoomer function #236

Open
wants to merge 3 commits into
base: update
Choose a base branch
from

Conversation

Nandana4
Copy link

@Nandana4 Nandana4 commented Oct 11, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Any PRs should be done to the update branch only

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Browsers Tested on?

  • Chrome
  • Firefox
  • Edge

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked the responsiveness of the component I built
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@adithya-r-prabhu
Copy link

Hey @Nandana4, you missed one more place to update the url (in src/js/popup.js)

check this for the exact line:
https://github.com/Nandana4/AutoJoomer/blob/504a4f7db638d3e46f8c56c075203ff3c995d2f8/src/js/popup.js#L114

thank you

@vishal-lokare
Copy link
Owner

@Nandana4 reply on the main issue first to get assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants