Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added react component for vf-card #1632

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

nitinja
Copy link
Contributor

@nitinja nitinja commented Jul 23, 2021

No description provided.

@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ Deploy Preview for ecstatic-noether-150ab4 ready!

🔨 Explore the source changes: baee0fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-noether-150ab4/deploys/6102562f7bf6ec00075fb383

😎 Browse the preview: https://deploy-preview-1632--ecstatic-noether-150ab4.netlify.app

@nitinja nitinja requested a review from khawkins98 July 23, 2021 11:33
@@ -0,0 +1,75 @@
import { VfClassNormalize } from "../../tools/vf-extensions-react/vf-extensions-react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once shipped to npm this should be:

import { VfClassNormalize } from "@visual-framework/vf-extensions-react/vf-extensions-react";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants