diff --git a/components/vf-news-container/CHANGELOG.md b/components/vf-news-container/CHANGELOG.md index ad898744b..60f8a815d 100755 --- a/components/vf-news-container/CHANGELOG.md +++ b/components/vf-news-container/CHANGELOG.md @@ -1,3 +1,7 @@ +### 1.1.1 + +* Updated: Made the image in news feed clickable [Tracking issue](https://github.com/visual-framework/vf-core/issues/1750) + ### 1.1.0 * Standardizes the featured news variant as 4 columns. diff --git a/components/vf-news-container/README.md b/components/vf-news-container/README.md index b1ab1db10..9378fd3ed 100755 --- a/components/vf-news-container/README.md +++ b/components/vf-news-container/README.md @@ -6,6 +6,10 @@ Use this component to show a section of news content. It also offers a `vf-news-container--featured` variant with support for `vf-summary` for when news is a higher level and, well, featured content on layout. +### Recommendations + +In a case where the descriptive text on the image is a repetition of the adjacent text, it is recommended to use a null alternative text on the image + ## Install This component is distributed with npm. After [installing npm](https://www.npmjs.com/get-npm), you can install the `vf-news-container` with this command. diff --git a/components/vf-news-container/vf-news-container--featured.njk b/components/vf-news-container/vf-news-container--featured.njk index 145a6898e..21542fcc9 100755 --- a/components/vf-news-container/vf-news-container--featured.njk +++ b/components/vf-news-container/vf-news-container--featured.njk @@ -3,7 +3,7 @@
{% render '@vf-summary--news-has-image', { - summary__href: 'JavaScript:Void(0);', + summary__href: '', summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", summary__image_alt: "BioSamples", summary__title: "news article summary", @@ -11,7 +11,7 @@ summary__date: "4 September 2019" } %} {% render '@vf-summary--news-has-image', { - summary__href: 'JavaScript:Void(0);', + summary__href: '', summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", summary__image_alt: "BioSamples", summary__title: "news article summary", @@ -19,7 +19,7 @@ summary__date: "4 September 2019" } %} {% render '@vf-summary--news-has-image', { - summary__href: 'JavaScript:Void(0);', + summary__href: '', summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", summary__image_alt: "BioSamples", summary__title: "news article summary", @@ -27,7 +27,7 @@ summary__date: "4 September 2019" } %} {% render '@vf-summary--news-has-image', { - summary__href: 'JavaScript:Void(0);', + summary__href: '', summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", summary__image_alt: "BioSamples", summary__title: "news article summary", diff --git a/components/vf-news-container/vf-news-container.njk b/components/vf-news-container/vf-news-container.njk index a91ff22c2..e8c217124 100755 --- a/components/vf-news-container/vf-news-container.njk +++ b/components/vf-news-container/vf-news-container.njk @@ -2,9 +2,38 @@ {% render '@vf-section-header'%}
- {% render '@vf-summary--news-has-image' %} - {% render '@vf-summary--news-has-image' %} - {% render '@vf-summary--news-has-image' %} + {% render '@vf-summary--news-has-image', { + summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", + summary__image_alt: "News image alt", + summary__text: "Combinations of cancer drugs can be quickly and cheaply tested using a novel microfluidic device.", + summary__date: "4 September 2019", + summary__href: "", + summary__title: "news article summary" + } %} + {% render '@vf-summary--news-has-image', { + summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", + summary__image_alt: "News image alt", + summary__text: "Combinations of cancer drugs can be quickly and cheaply tested using a novel microfluidic device.", + summary__date: "4 September 2019", + summary__href: "", + summary__title: "news article summary" + } %} + {% render '@vf-summary--news-has-image', { + summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", + summary__image_alt: "News image alt", + summary__text: "Combinations of cancer drugs can be quickly and cheaply tested using a novel microfluidic device.", + summary__date: "4 September 2019", + summary__href: "", + summary__title: "news article summary" + } %} + {% render '@vf-summary--news-has-image', { + summary__image: "../../assets/vf-summary/assets/vf-summary--news-has-image.jpg", + summary__image_alt: "News image alt", + summary__text: "Combinations of cancer drugs can be quickly and cheaply tested using a novel microfluidic device.", + summary__date: "4 September 2019", + summary__href: "", + summary__title: "news article summary" + } %}