Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to chokidar v4 #18129

Closed
4 tasks done
benmccann opened this issue Sep 17, 2024 · 2 comments · Fixed by #18453
Closed
4 tasks done

Upgrade to chokidar v4 #18129

benmccann opened this issue Sep 17, 2024 · 2 comments · Fixed by #18453
Labels
breaking change dependencies Pull requests that update a dependency file enhancement: pending triage
Milestone

Comments

@benmccann
Copy link
Collaborator

benmccann commented Sep 17, 2024

Description

Chokidar v4 is out now so can upgrade to it

Suggested solution

Should be done as part of a major since it's a bit breaking. Vite isn't using globs which were removed and disables them with disableGlobbing, but plugins can unfortunately hack around it like this

Alternative

No response

Additional context

Rollup will upgrade in 5.0: rollup/rollup#5656 (comment)

Validations

@benmccann benmccann added dependencies Pull requests that update a dependency file enhancement: pending triage breaking change labels Sep 17, 2024
@benmccann benmccann added this to the 6.0 milestone Sep 17, 2024
@sapphi-red
Copy link
Member

Vite isn't using globs which were removed

Vite supports glob in ignored option.

const ignored: WatchOptions['ignored'] = [
'**/.git/**',
'**/node_modules/**',
'**/test-results/**', // Playwright
glob.escapePath(cacheDir) + '/**',
...arraify(ignoredList || []),
]

@ghiscoding
Copy link
Contributor

just a side note, glob is not directly supported by chokidar but they do mention that it's supported in other ways by reading glob from node:fs or node-glob see the Chokidar upgrading section for that

https://github.com/paulmillr/chokidar?tab=readme-ov-file#upgrading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change dependencies Pull requests that update a dependency file enhancement: pending triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants