Remove unnecessary/unwanted sort in UpdateVReplicationWorkflow

mattlord · mattlord · commit a9631d234126 · 2024-02-07T12:53:52.000-05:00
We're only supposed to be potentially updating the OnDDL flag
there.

Signed-off-by: Matt Lord &lt;mattalord@gmail.com&gt;
diff --git a/go/vt/vttablet/tabletmanager/rpc_vreplication.go b/go/vt/vttablet/tabletmanager/rpc_vreplication.go
@@ -296,7 +296,6 @@ func (tm *TabletManager) UpdateVReplicationWorkflow(ctx context.Context, req *ta
 		if !textutil.ValueIsSimulatedNull(req.OnDdl) {
 			bls.OnDdl = req.OnDdl
 		}
-		protoutil.SortBinlogSourceTables(bls)
 		source, err = prototext.Marshal(bls)
 		if err != nil {
 			return nil, err

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,6 @@ func (tm TabletManager) UpdateVReplicationWorkflow(ctx context.Context, req ta`
`296`	`296`	`if !textutil.ValueIsSimulatedNull(req.OnDdl) {`
`297`	`297`	`bls.OnDdl = req.OnDdl`
`298`	`298`	`}`
`299`		`- protoutil.SortBinlogSourceTables(bls)`
`300`	`299`	`source, err = prototext.Marshal(bls)`
`301`	`300`	`if err != nil {`
`302`	`301`	`return nil, err`