Skip to content

Commit bc8cd61

Browse files
committed
test: fix test expectations
Signed-off-by: Manan Gupta <manan@planetscale.com>
1 parent c3bbce2 commit bc8cd61

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

go/test/endtoend/vtgate/queries/timeout/timeout_test.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package misc
1818

1919
import (
2020
"context"
21+
"strings"
2122
"testing"
2223

2324
"github.com/stretchr/testify/assert"
@@ -194,13 +195,18 @@ func TestOverallQueryTimeout(t *testing.T) {
194195
// take 2 and 3 seconds each to run. If we have an overall timeout for 4 seconds, then it should fail.
195196
_, err := utils.ExecAllowError(t, mcmp.VtConn, "select /*vt+ QUERY_TIMEOUT_MS=4000 */ sleep(u2.id2), u1.id2 from t1 u1 join t1 u2 where u1.id2 = u2.id1")
196197
assert.Error(t, err)
197-
assert.ErrorContains(t, err, "DeadlineExceeded desc = context deadline exceeded (errno 1317) (sqlstate 70100)")
198+
// We can get two different error messages based on whether it is coming from vttablet or vtgate
199+
if !strings.Contains(err.Error(), "Query execution was interrupted, maximum statement execution time exceeded") {
200+
assert.ErrorContains(t, err, "DeadlineExceeded desc = context deadline exceeded (errno 1317) (sqlstate 70100)")
201+
}
198202

199203
// Let's also check that setting the session variable also works.
200204
utils.Exec(t, mcmp.VtConn, "set query_timeout=4000")
201205
_, err = utils.ExecAllowError(t, mcmp.VtConn, "select sleep(u2.id2), u1.id2 from t1 u1 join t1 u2 where u1.id2 = u2.id1")
202206
assert.Error(t, err)
203-
assert.ErrorContains(t, err, "DeadlineExceeded desc = context deadline exceeded (errno 1317) (sqlstate 70100)")
207+
if !strings.Contains(err.Error(), "Query execution was interrupted, maximum statement execution time exceeded") {
208+
assert.ErrorContains(t, err, "DeadlineExceeded desc = context deadline exceeded (errno 1317) (sqlstate 70100)")
209+
}
204210

205211
// Increasing the timeout should pass the query.
206212
utils.Exec(t, mcmp.VtConn, "set query_timeout=10000")

0 commit comments

Comments
 (0)