Skip to content

Commit ca4246d

Browse files
dbussinkdbussink
authored
Refactor out more usage of servenv for mysql version (#14938)
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
1 parent 42afc72 commit ca4246d

File tree

182 files changed

+1114
-877
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+1114
-877
lines changed

‎go/cmd/vtadmin/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,11 @@ func run(cmd *cobra.Command, args []string) {
139139
log.Warningf("no cache-refresh-key set; forcing cache refreshes will not be possible")
140140
}
141141
cache.SetCacheRefreshKey(cacheRefreshKey)
142-
collationEnv := collations.NewEnvironment(servenv.MySQLServerVersion())
142+
mysqlServerVersion := servenv.MySQLServerVersion()
143+
collationEnv := collations.NewEnvironment(mysqlServerVersion)
143144

144145
parser, err := sqlparser.New(sqlparser.Options{
145-
MySQLServerVersion: servenv.MySQLServerVersion(),
146+
MySQLServerVersion: mysqlServerVersion,
146147
TruncateUILen: servenv.TruncateUILen,
147148
TruncateErrLen: servenv.TruncateErrLen,
148149
})
@@ -154,7 +155,7 @@ func run(cmd *cobra.Command, args []string) {
154155
HTTPOpts: httpOpts,
155156
RBAC: rbacConfig,
156157
EnableDynamicClusters: enableDynamicClusters,
157-
}, collationEnv, parser)
158+
}, collationEnv, parser, mysqlServerVersion)
158159
bootSpan.Finish()
159160

160161
if err := s.ListenAndServe(); err != nil {

‎go/cmd/vtcombo/cli/main.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ In particular, it contains:
8383
collationEnv *collations.Environment
8484
resilientServer *srvtopo.ResilientServer
8585
parser *sqlparser.Parser
86+
mysqlVersion string
8687
)
8788

8889
func init() {
@@ -192,8 +193,9 @@ func run(cmd *cobra.Command, args []string) (err error) {
192193
servenv.Init()
193194
tabletenv.Init()
194195

196+
mysqlVersion = servenv.MySQLServerVersion()
195197
parser, err = sqlparser.New(sqlparser.Options{
196-
MySQLServerVersion: servenv.MySQLServerVersion(),
198+
MySQLServerVersion: mysqlVersion,
197199
TruncateUILen: servenv.TruncateUILen,
198200
TruncateErrLen: servenv.TruncateErrLen,
199201
})
@@ -232,7 +234,7 @@ func run(cmd *cobra.Command, args []string) (err error) {
232234
// to be the "internal" protocol that InitTabletMap registers.
233235
cmd.Flags().Set("tablet_manager_protocol", "internal")
234236
cmd.Flags().Set("tablet_protocol", "internal")
235-
uid, err := vtcombo.InitTabletMap(ts, &tpb, mysqld, &dbconfigs.GlobalDBConfigs, schemaDir, startMysql, collationEnv, parser)
237+
uid, err := vtcombo.InitTabletMap(ts, &tpb, mysqld, &dbconfigs.GlobalDBConfigs, schemaDir, startMysql, collationEnv, parser, mysqlVersion)
236238
if err != nil {
237239
// ensure we start mysql in the event we fail here
238240
if startMysql {
@@ -257,8 +259,8 @@ func run(cmd *cobra.Command, args []string) (err error) {
257259
}
258260
}
259261

260-
wr := wrangler.New(logutil.NewConsoleLogger(), ts, nil, collationEnv, parser)
261-
newUID, err := vtcombo.CreateKs(ctx, ts, &tpb, mysqld, &dbconfigs.GlobalDBConfigs, schemaDir, ks, true, uid, wr, collationEnv, parser)
262+
wr := wrangler.New(logutil.NewConsoleLogger(), ts, nil, collationEnv, parser, mysqlVersion)
263+
newUID, err := vtcombo.CreateKs(ctx, ts, &tpb, mysqld, &dbconfigs.GlobalDBConfigs, schemaDir, ks, true, uid, wr, collationEnv, parser, mysqlVersion)
262264
if err != nil {
263265
return err
264266
}
@@ -308,10 +310,10 @@ func run(cmd *cobra.Command, args []string) (err error) {
308310
vtgate.QueryzHandler = "/debug/vtgate/queryz"
309311

310312
// pass nil for healthcheck, it will get created
311-
vtg := vtgate.Init(context.Background(), nil, resilientServer, tpb.Cells[0], tabletTypesToWait, plannerVersion, collationEnv)
313+
vtg := vtgate.Init(context.Background(), nil, resilientServer, tpb.Cells[0], tabletTypesToWait, plannerVersion, collationEnv, mysqlVersion)
312314

313315
// vtctld configuration and init
314-
err = vtctld.InitVtctld(ts, collationEnv, parser)
316+
err = vtctld.InitVtctld(ts, collationEnv, parser, mysqlVersion)
315317
if err != nil {
316318
return err
317319
}

‎go/cmd/vtcombo/cli/plugin_grpcvtctldserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
func init() {
2525
servenv.OnRun(func() {
2626
if servenv.GRPCCheckServiceMap("vtctld") {
27-
grpcvtctldserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser)
27+
grpcvtctldserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser, mysqlVersion)
2828
}
2929
})
3030
}

‎go/cmd/vtcombo/cli/plugin_grpcvtctlserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
func init() {
2525
servenv.OnRun(func() {
2626
if servenv.GRPCCheckServiceMap("vtctl") {
27-
grpcvtctlserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser)
27+
grpcvtctlserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser, mysqlVersion)
2828
}
2929
})
3030
}

‎go/cmd/vtctl/vtctl.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,11 @@ func main() {
131131
ctx, cancel := context.WithTimeout(context.Background(), waitTime)
132132
installSignalHandlers(cancel)
133133

134-
collationEnv := collations.NewEnvironment(servenv.MySQLServerVersion())
134+
mysqlVersion := servenv.MySQLServerVersion()
135+
collationEnv := collations.NewEnvironment(mysqlVersion)
135136

136137
parser, err := sqlparser.New(sqlparser.Options{
137-
MySQLServerVersion: servenv.MySQLServerVersion(),
138+
MySQLServerVersion: mysqlVersion,
138139
TruncateUILen: servenv.TruncateUILen,
139140
TruncateErrLen: servenv.TruncateErrLen,
140141
})
@@ -166,7 +167,7 @@ func main() {
166167
// New behavior. Strip off the prefix, and set things up to run through
167168
// the vtctldclient command tree, using the localvtctldclient (in-process)
168169
// client.
169-
vtctld := grpcvtctldserver.NewVtctldServer(ts, collationEnv, parser)
170+
vtctld := grpcvtctldserver.NewVtctldServer(ts, collationEnv, parser, mysqlVersion)
170171
localvtctldclient.SetServer(vtctld)
171172
command.VtctldClientProtocol = "local"
172173

@@ -182,7 +183,7 @@ func main() {
182183
fallthrough
183184
default:
184185
log.Warningf("WARNING: vtctl should only be used for VDiff v1 workflows. Please use VDiff v2 and consider using vtctldclient for all other commands.")
185-
wr := wrangler.New(logutil.NewConsoleLogger(), ts, tmclient.NewTabletManagerClient(), collationEnv, parser)
186+
wr := wrangler.New(logutil.NewConsoleLogger(), ts, tmclient.NewTabletManagerClient(), collationEnv, parser, mysqlVersion)
186187

187188
if args[0] == "--" {
188189
vtctl.PrintDoubleDashDeprecationNotice(wr)

‎go/cmd/vtctld/cli/cli.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ var (
3232
ts *topo.Server
3333
collationEnv *collations.Environment
3434
parser *sqlparser.Parser
35+
mysqlVersion string
3536
Main = &cobra.Command{
3637
Use: "vtctld",
3738
Short: "The Vitess cluster management daemon.",
@@ -65,17 +66,18 @@ func run(cmd *cobra.Command, args []string) error {
6566
defer ts.Close()
6667

6768
var err error
68-
collationEnv = collations.NewEnvironment(servenv.MySQLServerVersion())
69+
mysqlVersion = servenv.MySQLServerVersion()
70+
collationEnv = collations.NewEnvironment(mysqlVersion)
6971
parser, err = sqlparser.New(sqlparser.Options{
70-
MySQLServerVersion: servenv.MySQLServerVersion(),
72+
MySQLServerVersion: mysqlVersion,
7173
TruncateUILen: servenv.TruncateUILen,
7274
TruncateErrLen: servenv.TruncateErrLen,
7375
})
7476
if err != nil {
7577
return err
7678
}
7779
// Init the vtctld core
78-
if err := vtctld.InitVtctld(ts, collationEnv, parser); err != nil {
80+
if err := vtctld.InitVtctld(ts, collationEnv, parser, mysqlVersion); err != nil {
7981
return err
8082
}
8183

‎go/cmd/vtctld/cli/plugin_grpcvtctldserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
func init() {
2525
servenv.OnRun(func() {
2626
if servenv.GRPCCheckServiceMap("vtctld") {
27-
grpcvtctldserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser)
27+
grpcvtctldserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser, mysqlVersion)
2828
}
2929
})
3030
}

‎go/cmd/vtctld/cli/plugin_grpcvtctlserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
func init() {
2525
servenv.OnRun(func() {
2626
if servenv.GRPCCheckServiceMap("vtctl") {
27-
grpcvtctlserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser)
27+
grpcvtctlserver.StartServer(servenv.GRPCServer, ts, collationEnv, parser, mysqlVersion)
2828
}
2929
})
3030
}

‎go/cmd/vtctld/cli/schema.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func initSchema() {
7171
return
7272
}
7373
ctx := context.Background()
74-
wr := wrangler.New(logutil.NewConsoleLogger(), ts, tmclient.NewTabletManagerClient(), collationEnv, parser)
74+
wr := wrangler.New(logutil.NewConsoleLogger(), ts, tmclient.NewTabletManagerClient(), collationEnv, parser, mysqlVersion)
7575
_, err = schemamanager.Run(
7676
ctx,
7777
controller,

‎go/cmd/vtctldclient/command/root.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ var (
8585

8686
collationEnv *collations.Environment
8787
parser *sqlparser.Parser
88+
mysqlVersion string
8889

8990
topoOptions = struct {
9091
implementation string
@@ -214,7 +215,7 @@ func getClientForCommand(cmd *cobra.Command) (vtctldclient.VtctldClient, error)
214215
return nil
215216
})
216217
})
217-
vtctld := grpcvtctldserver.NewVtctldServer(ts, collationEnv, parser)
218+
vtctld := grpcvtctldserver.NewVtctldServer(ts, collationEnv, parser, mysqlVersion)
218219
localvtctldclient.SetServer(vtctld)
219220
VtctldClientProtocol = "local"
220221
server = ""
@@ -232,10 +233,11 @@ func init() {
232233
Root.PersistentFlags().StringVar(&topoOptions.globalRoot, "topo-global-root", topoOptions.globalRoot, "the path of the global topology data in the global topology server")
233234
vreplcommon.RegisterCommands(Root)
234235

235-
collationEnv = collations.NewEnvironment(servenv.MySQLServerVersion())
236+
mysqlVersion = servenv.MySQLServerVersion()
237+
collationEnv = collations.NewEnvironment(mysqlVersion)
236238
var err error
237239
parser, err = sqlparser.New(sqlparser.Options{
238-
MySQLServerVersion: servenv.MySQLServerVersion(),
240+
MySQLServerVersion: mysqlVersion,
239241
TruncateUILen: servenv.TruncateUILen,
240242
TruncateErrLen: servenv.TruncateErrLen,
241243
})

‎go/cmd/vtctldclient/command/vreplication/common/utils_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"vitess.io/vitess/go/cmd/vtctldclient/command"
2828
"vitess.io/vitess/go/cmd/vtctldclient/command/vreplication/common"
2929
"vitess.io/vitess/go/mysql/collations"
30+
"vitess.io/vitess/go/mysql/config"
3031
"vitess.io/vitess/go/vt/sqlparser"
3132
"vitess.io/vitess/go/vt/topo"
3233
"vitess.io/vitess/go/vt/topo/memorytopo"
@@ -146,7 +147,7 @@ func SetupLocalVtctldClient(t *testing.T, ctx context.Context, cells ...string)
146147
tmclient.RegisterTabletManagerClientFactory("grpc", func() tmclient.TabletManagerClient {
147148
return nil
148149
})
149-
vtctld := grpcvtctldserver.NewVtctldServer(ts, collations.MySQL8(), sqlparser.NewTestParser())
150+
vtctld := grpcvtctldserver.NewVtctldServer(ts, collations.MySQL8(), sqlparser.NewTestParser(), config.DefaultMySQLVersion)
150151
localvtctldclient.SetServer(vtctld)
151152
command.VtctldClientProtocol = "local"
152153
client, err := vtctldclient.New(command.VtctldClientProtocol, "")

‎go/cmd/vtctldclient/command/vreplication/vdiff/vdiff_env_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"testing"
2727

2828
"vitess.io/vitess/go/mysql/collations"
29+
"vitess.io/vitess/go/mysql/config"
2930
"vitess.io/vitess/go/sqltypes"
3031
"vitess.io/vitess/go/vt/grpcclient"
3132
"vitess.io/vitess/go/vt/sqlparser"
@@ -85,7 +86,7 @@ func newTestVDiffEnv(t testing.TB, ctx context.Context, sourceShards, targetShar
8586
tabletType: topodatapb.TabletType_REPLICA,
8687
tmc: newTestVDiffTMClient(),
8788
}
88-
env.ws = workflow.NewServer(env.topoServ, env.tmc, collations.MySQL8(), sqlparser.NewTestParser())
89+
env.ws = workflow.NewServer(env.topoServ, env.tmc, collations.MySQL8(), sqlparser.NewTestParser(), config.DefaultMySQLVersion)
8990
env.tmc.testEnv = env
9091

9192
// Generate a unique dialer name.

‎go/cmd/vtexplain/cli/vtexplain.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,16 +175,17 @@ func parseAndRun() error {
175175
Target: dbName,
176176
}
177177

178-
collationEnv := collations.NewEnvironment(servenv.MySQLServerVersion())
178+
mysqlServerVersion := servenv.MySQLServerVersion()
179+
collationEnv := collations.NewEnvironment(mysqlServerVersion)
179180
parser, err := sqlparser.New(sqlparser.Options{
180-
MySQLServerVersion: servenv.MySQLServerVersion(),
181+
MySQLServerVersion: mysqlServerVersion,
181182
TruncateUILen: servenv.TruncateUILen,
182183
TruncateErrLen: servenv.TruncateErrLen,
183184
})
184185
if err != nil {
185186
return err
186187
}
187-
vte, err := vtexplain.Init(context.Background(), vschema, schema, ksShardMap, opts, collationEnv, parser)
188+
vte, err := vtexplain.Init(context.Background(), vschema, schema, ksShardMap, opts, collationEnv, parser, mysqlServerVersion)
188189
if err != nil {
189190
return err
190191
}

‎go/cmd/vtgate/cli/cli.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,12 @@ func run(cmd *cobra.Command, args []string) error {
158158
return fmt.Errorf("cells_to_watch validation failed: %v", err)
159159
}
160160

161+
mysqlVersion := servenv.MySQLServerVersion()
161162
plannerVersion, _ := plancontext.PlannerNameToVersion(plannerName)
162-
collationEnv := collations.NewEnvironment(servenv.MySQLServerVersion())
163+
collationEnv := collations.NewEnvironment(mysqlVersion)
163164

164165
// pass nil for HealthCheck and it will be created
165-
vtg := vtgate.Init(context.Background(), nil, resilientServer, cell, tabletTypes, plannerVersion, collationEnv)
166+
vtg := vtgate.Init(context.Background(), nil, resilientServer, cell, tabletTypes, plannerVersion, collationEnv, mysqlVersion)
166167

167168
servenv.OnRun(func() {
168169
// Flags are parsed now. Parse the template using the actual flag value and overwrite the current template.

‎go/cmd/vttablet/cli/cli.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,24 +112,25 @@ func run(cmd *cobra.Command, args []string) error {
112112
return fmt.Errorf("failed to parse --tablet-path: %w", err)
113113
}
114114

115+
mysqlVersion := servenv.MySQLServerVersion()
115116
parser, err := sqlparser.New(sqlparser.Options{
116-
MySQLServerVersion: servenv.MySQLServerVersion(),
117+
MySQLServerVersion: mysqlVersion,
117118
TruncateUILen: servenv.TruncateUILen,
118119
TruncateErrLen: servenv.TruncateErrLen,
119120
})
120121
if err != nil {
121122
return fmt.Errorf("cannot initialize sql parser: %w", err)
122123
}
123124

124-
collationEnv := collations.NewEnvironment(servenv.MySQLServerVersion())
125+
collationEnv := collations.NewEnvironment(mysqlVersion)
125126
// config and mycnf initializations are intertwined.
126127
config, mycnf, err := initConfig(tabletAlias, collationEnv)
127128
if err != nil {
128129
return err
129130
}
130131

131132
ts := topo.Open()
132-
qsc, err := createTabletServer(context.Background(), config, ts, tabletAlias, collationEnv, parser)
133+
qsc, err := createTabletServer(context.Background(), config, ts, tabletAlias, collationEnv, parser, mysqlVersion)
133134
if err != nil {
134135
ts.Close()
135136
return err
@@ -142,9 +143,8 @@ func run(cmd *cobra.Command, args []string) error {
142143
ts.Close()
143144
return fmt.Errorf("failed to extract online DDL binaries: %w", err)
144145
}
145-
146146
parser, err = sqlparser.New(sqlparser.Options{
147-
MySQLServerVersion: servenv.MySQLServerVersion(),
147+
MySQLServerVersion: mysqlVersion,
148148
TruncateUILen: servenv.TruncateUILen,
149149
TruncateErrLen: servenv.TruncateErrLen,
150150
})
@@ -168,10 +168,11 @@ func run(cmd *cobra.Command, args []string) error {
168168
DBConfigs: config.DB.Clone(),
169169
QueryServiceControl: qsc,
170170
UpdateStream: binlog.NewUpdateStream(ts, tablet.Keyspace, tabletAlias.Cell, qsc.SchemaEngine(), parser),
171-
VREngine: vreplication.NewEngine(config, ts, tabletAlias.Cell, mysqld, qsc.LagThrottler(), collationEnv, parser),
171+
VREngine: vreplication.NewEngine(config, ts, tabletAlias.Cell, mysqld, qsc.LagThrottler(), collationEnv, parser, mysqlVersion),
172172
VDiffEngine: vdiff.NewEngine(ts, tablet, collationEnv, parser),
173173
CollationEnv: collationEnv,
174174
SQLParser: parser,
175+
MySQLVersion: mysqlVersion,
175176
}
176177
if err := tm.Start(tablet, config); err != nil {
177178
ts.Close()
@@ -259,7 +260,7 @@ func extractOnlineDDL() error {
259260
return nil
260261
}
261262

262-
func createTabletServer(ctx context.Context, config *tabletenv.TabletConfig, ts *topo.Server, tabletAlias *topodatapb.TabletAlias, collationEnv *collations.Environment, parser *sqlparser.Parser) (*tabletserver.TabletServer, error) {
263+
func createTabletServer(ctx context.Context, config *tabletenv.TabletConfig, ts *topo.Server, tabletAlias *topodatapb.TabletAlias, collationEnv *collations.Environment, parser *sqlparser.Parser, mysqlVersion string) (*tabletserver.TabletServer, error) {
263264
if tableACLConfig != "" {
264265
// To override default simpleacl, other ACL plugins must set themselves to be default ACL factory
265266
tableacl.Register("simpleacl", &simpleacl.Factory{})
@@ -268,7 +269,7 @@ func createTabletServer(ctx context.Context, config *tabletenv.TabletConfig, ts
268269
}
269270

270271
// creates and registers the query service
271-
qsc := tabletserver.NewTabletServer(ctx, "", config, ts, tabletAlias, collationEnv, parser)
272+
qsc := tabletserver.NewTabletServer(ctx, "", config, ts, tabletAlias, collationEnv, parser, mysqlVersion)
272273
servenv.OnRun(func() {
273274
qsc.Register()
274275
addStatusParts(qsc)

‎go/test/fuzzing/tabletserver_schema_fuzzer.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"time"
2121

2222
"vitess.io/vitess/go/mysql/collations"
23+
"vitess.io/vitess/go/mysql/config"
2324
"vitess.io/vitess/go/mysql/fakesqldb"
2425
"vitess.io/vitess/go/sqltypes"
2526
"vitess.io/vitess/go/vt/dbconfigs"
@@ -68,7 +69,7 @@ func newTestLoadTable(tableName, comment string, db *fakesqldb.DB) (*schema.Tabl
6869
IdleTimeout: 10 * time.Second,
6970
}
7071

71-
connPool := connpool.NewPool(tabletenv.NewEnv(nil, "SchemaTest", collations.MySQL8(), sqlparser.NewTestParser()), "", cfg)
72+
connPool := connpool.NewPool(tabletenv.NewEnv(nil, "SchemaTest", collations.MySQL8(), sqlparser.NewTestParser(), config.DefaultMySQLVersion), "", cfg)
7273
connPool.Open(appParams, dbaParams, appParams)
7374
conn, err := connPool.Get(ctx, nil)
7475
if err != nil {

‎go/test/fuzzing/vtctl_fuzzer.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"strings"
2222

2323
"vitess.io/vitess/go/mysql/collations"
24+
"vitess.io/vitess/go/mysql/config"
2425
"vitess.io/vitess/go/vt/logutil"
2526
"vitess.io/vitess/go/vt/sqlparser"
2627
"vitess.io/vitess/go/vt/topo"
@@ -182,7 +183,7 @@ func Fuzz(data []byte) int {
182183
// Add params to the command
183184
commandSlice = append(commandSlice, args...)
184185

185-
_ = vtctl.RunCommand(ctx, wrangler.New(logger, topo, tmc, collations.MySQL8(), sqlparser.NewTestParser()), commandSlice)
186+
_ = vtctl.RunCommand(ctx, wrangler.New(logger, topo, tmc, collations.MySQL8(), sqlparser.NewTestParser(), config.DefaultMySQLVersion), commandSlice)
186187
command++
187188
}
188189

0 commit comments

Comments
 (0)