Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlannedReparentShard should allow automatic replica selection even when cross cell boundaries #6532

Closed
aquarapid opened this issue Aug 4, 2020 · 1 comment
Labels
Component: Cluster management Component: VTorc Vitess Orchestrator integration Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@aquarapid
Copy link
Contributor

Currently PRS allows user to not specify a -new_master option. In this case, PRS will automatically choose a replica that is "reasonable" for promotion.

However, this logic only works for reparenting to a replica in the same cell as the current master. If you want to cross cells with the reparenting, you need to explicitly provide a -new_master tablet name.

We should remove this limitation, and allow PRS to take a destination cell as a parameter, and then use the existing internal logic to chose the most up-to-date replica in that cell.

@aquarapid aquarapid added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Aug 4, 2020
@ajm188 ajm188 added Component: Cluster management Component: VTorc Vitess Orchestrator integration labels Jun 24, 2022
@GuptaManan100
Copy link
Member

Resolved by #16461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Component: VTorc Vitess Orchestrator integration Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

No branches or pull requests

3 participants