Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Improve CI/Release Pipeline #237

Open
zmitchell opened this issue Aug 6, 2018 · 3 comments
Open

Improve CI/Release Pipeline #237

zmitchell opened this issue Aug 6, 2018 · 3 comments

Comments

@zmitchell
Copy link

Ok, so since I've never done this before, what does the CI system currently do, and what does it need to do?

@vitiral
Copy link
Owner

vitiral commented Aug 6, 2018 via email

@zmitchell
Copy link
Author

I'm finally working on this (I was finishing up an unrelated blog post). I'm getting some tests running and I got an error in one of the tests:

error: cannot find derive macro `Deserialize` in this scope
 --> tests/data_raw_names.rs:9:35
  |
9 | #[derive(Debug, Clone, Serialize, Deserialize)]
  |                                   ^^^^^^^^^^^

This error shows up for all of the Serialize/Deserialize derives in tests/data_raw_names.rs. If I add

#[macro_use] extern crate serde_derive;

to the file, the tests work. I'm not sure if that's something that was working on your end, or if it was already broken.

@vitiral
Copy link
Owner

vitiral commented Aug 20, 2018

it's weird but it may be because it (for some reason) compiled in nightly which is what I frequently use.

I suggest you use:

pub extern crate ergo;
use ergo::*;

This is how most other files do it. I just include everything from ergo all the time to avoid these single-dependency inclusions for extremely common traits.

Happy you're working on it! Feel free to make any changes to get things working and I'll be happy to review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants