Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

SV: server #85

Closed
17 tasks done
vitiral opened this issue Mar 2, 2017 · 3 comments
Closed
17 tasks done

SV: server #85

vitiral opened this issue Mar 2, 2017 · 3 comments

Comments

@vitiral
Copy link
Owner

vitiral commented Mar 2, 2017

As part of the 1.0 release, the server functionality will be hidden behind a feature flag and development will continue in the "server" branch.

The export cmd will still be supported for generating static html.

The server will not necessarily compile anymore if the mainline repo. Documentation on how to compile the server will be added to the installation guide.

This will prevent backwards incompatible changes and thrashing to mainline. Any core changes that are needed for server development will have to be done to mainline through a PR.

Once the api is complete on the server, it will be merged into mainline so that frontend work can be done without forking.

Tasks

  • API Calls:
    • DeleteArtifacts
    • CreateArtifacts
    • UpdateArtifacts
    • ReadArtifacts -> ReadProject: we need more information from the server than just the artifacts. For changing things it will go through the above, but for reading you will always get the whole project. (we need at least the files)
  • Web UI tasks:
  • art serve fixes
    • make -e url and -r url flags. -e will put you in an editable mode at the url and will have a warning that it is exteremely unsafe
    • make -p flag to specify an alternate port on localhost. By default art serve will make an editable instance on local host at port 5373 (SETS)
    • handle SIGINT gracefully
vitiral added a commit that referenced this issue Mar 3, 2017
- The api and server are hidden behind it
@vitiral vitiral changed the title feature: server SV: server Mar 3, 2017
@vitiral vitiral added Epic and removed Epic labels Mar 3, 2017
@einsweniger
Copy link
Contributor

einsweniger commented May 29, 2017

I think I see a CRUD pattern for the API, but ReadArtifact is missing. Is that omission deliberate?

@vitiral
Copy link
Owner Author

vitiral commented May 29, 2017

I make everything plural and I named it GetArtifacts. I would be fine renaming to ReadArtifacts

@vitiral
Copy link
Owner Author

vitiral commented Jun 14, 2017

@einsweniger the above change also changed GetArtifacts -> ReadArtifacts 😄

vitiral added a commit that referenced this issue Jun 27, 2017
This represents a huge amount of refactoring of the web-ui
along with several new selenium tests and improved e2e testing
framework.
@vitiral vitiral closed this as completed in 2af97cc Jul 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants