From 5171065166df841d9557b756f231c2b562c705e2 Mon Sep 17 00:00:00 2001
From: Marc Portier <marc.portier@gmail.com>
Date: Tue, 10 Dec 2024 19:07:32 +0000
Subject: [PATCH] introducing some env vars & example dotenv as suggested in
 #16

---
 .gitignore                 |  1 +
 docker/docker-compose.yaml | 14 +++++++-------
 docker/dotenv-example      | 11 +++++++++++
 3 files changed, 19 insertions(+), 7 deletions(-)
 create mode 100644 .gitignore
 create mode 100644 docker/dotenv-example

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..4c49bd7
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.env
diff --git a/docker/docker-compose.yaml b/docker/docker-compose.yaml
index ceb96c9..74a4847 100644
--- a/docker/docker-compose.yaml
+++ b/docker/docker-compose.yaml
@@ -31,13 +31,13 @@ services:
       # services are internal, you can adapt this URL to also be internal.
       - HMAC_KEY=CHANGE_ME
     ports:
-      - "8080:8080"
+      - "${GITB_SRV_PORT:-8080}:8080"
   gitb-ui:
     image: isaitb/gitb-ui
     container_name: itb-ui
     restart: unless-stopped
     ports:
-      - "9000:9000"
+      - "${GITB_UI_PORT:-9000}:9000"
     environment:
       - THEME=gitb
       - DB_DEFAULT_PASSWORD=CHANGE_ME
@@ -60,7 +60,7 @@ services:
     environment:
       JAVA_OPTS: "-Xmx4g -Xms4g"
     ports:
-      - "7200:7200"
+      - "${GRAPHDB_PORT:-7200}:7200"
 
   ldio-workbench:
     image: ldes/ldi-orchestrator:2.10.0-SNAPSHOT
@@ -71,7 +71,7 @@ services:
       timeout: 3s
       retries: 12
     ports:
-      - "8888:8080"
+      - "${LDIO_WB_PORT:-8888}:8080"
 
   testbed-shacl-validator:
     image: ghcr.io/informatievlaanderen/testbed-shacl-validator:20241113094029
@@ -81,6 +81,6 @@ services:
       ldio-workbench:
         condition: service_healthy
     environment:
-      - LDIO_HOST=http://ldio-workbench:8080
-      - LDIO_SPARQLHOST=http://graphdb:7200
-      - SERVER_PORT=8080
\ No newline at end of file
+      - LDIO_HOST=http://ldio-workbench:8080   # targets container-port (not exposed host-port)
+      - LDIO_SPARQLHOST=http://graphdb:7200    # idem
+      - SERVER_PORT=8080                       # looks like this needs to point to itb_srv port assumed also container based
diff --git a/docker/dotenv-example b/docker/dotenv-example
new file mode 100644
index 0000000..222ab32
--- /dev/null
+++ b/docker/dotenv-example
@@ -0,0 +1,11 @@
+# exported host port for the gitb-server service (whatever that may do)
+#GITB_SRV_PORT=9090
+
+# exported host port for the gitb-ui service (whatever that may do)
+#GITB_UI_PORT=9000
+
+# exported host port for the graphdb triple store service 
+#GRAPHDB_PORT=7200
+
+# exported host port for the LDIO Workbench service
+#LDIO_WB_PORT=8888