Skip to content

Conversation

@samzong
Copy link
Contributor

@samzong samzong commented Nov 28, 2025

FILL IN THE PR DESCRIPTION HERE

FIX #675 (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

…kend setup

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong requested a review from Xunzhuo as a code owner November 28, 2025 18:16
@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 414d985
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6929e7180d32aa00086a4f96
😎 Deploy Preview https://deploy-preview-741--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 website

Owners: @Xunzhuo, @rootfs, @yuluo-yx
Files changed:

  • website/docs/installation/configuration.md
  • website/docs/installation/installation.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@samzong
Copy link
Contributor Author

samzong commented Nov 28, 2025

@yuezhu1 @Xunzhuo PTAL.

Copy link
Collaborator

@yuezhu1 yuezhu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good to me. Just nitpicking


### 3. Monitoring (Optional)

By default, the router exposes Prometheus metrics at `:9190/metrics`. To disable monitoring:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the explanation for disabling the monitoring. I wonder if make run-router DISABLE_TRACING=true is a possible option for cli?

weight: 1
model_config:
"qwen3": # Must match --served-model-name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think if we start vllm via vllm serve Qwen/Qwen3-1.8B --port 8000, putting Qwen/Qwen3-1.8B for this name also work. Maybe consider including this into comment too?

- **HuggingFace CLI**: Required for fetching models

## Local Installation
## Installation Steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to switch back to Local Installation for better clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: Clarify Quick Local Installation

4 participants