Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity is not compatible with Analog (SSR) #984

Open
DmitryEfimenko opened this issue Oct 5, 2023 · 2 comments
Open

Clarity is not compatible with Analog (SSR) #984

DmitryEfimenko opened this issue Oct 5, 2023 · 2 comments

Comments

@DmitryEfimenko
Copy link

DmitryEfimenko commented Oct 5, 2023

This is a bug report for the @clr Angular or UI versions of the design system.

Describe the bug

Clarity is not compatible with Analog

How to reproduce

Steps to reproduce the behavior:

  1. Create an Analog app following the Getting Started instructions here
  2. Add Clarity following instructions here
  • The new app uses standalone components so there won't be an AppModule. Instead, add ClarityModule to the imports of the AppComponent
  1. Run npm start
  2. See error
ERROR Error: Uncaught (in promise): ReferenceError: window is not defined
ReferenceError: window is not defined
    at [path to the app]/node_modules/@cds/core/internal/utils/exists.js:1:209

Expected behavior

Application should run

Versions

Clarity version:

  • @cds/core: "6.7.0"
  • @clr/angular: "16.0.0"
  • @clr/ui: "16.0.0"

Framework version:

Angular 16

Device:

  • Type: Desktop
  • OS: Windows - running project on WSL 2
  • Browser: N/A
  • Version: N/A

Additional notes

I suspect there would be similar error even just for a standard Angular SSR integration

@kevinbuhmann
Copy link
Member

This is likely not something we will focus on supporting.

@DmitryEfimenko
Copy link
Author

Server-side rendering is important for many, many apps these days. Not supporting SSR, will automatically remove Clarity as an option for many projects.

I hope you'll reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants