Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce CPU & Memory requests for Velero UpgradeCRDs Job #513

Closed
Miraj50 opened this issue Oct 31, 2023 · 1 comment
Closed

Reduce CPU & Memory requests for Velero UpgradeCRDs Job #513

Miraj50 opened this issue Oct 31, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request velero

Comments

@Miraj50
Copy link
Contributor

Miraj50 commented Oct 31, 2023

Describe the problem/challenge you have
The upgradeCRDs job just runs a couple of commands to get the latest CRDs from the velero binary and kubectl apply it in the cluster. It's a small short-lived operation. But if we look at the resource requests of the upgrade job pod, it's the same as the velero server pod which by default is high (500m CPU and 128Mi of memory). Requesting such a high amount of resources is worrisome for clusters which do not have that much of reserved space available. Testing on such clusters, we'can see the upgradeJob pod getting stuck and the upgrade never going through.

Describe the solution you'd like
We should make separate sections under resources for the velero server and the upgradeJob. The upgradeJob will have much lesser resource requirements than the velero server pod.
Here's a suggestion:

upgradeJobResources:
  requests:
    cpu: 50m
    memory: 64Mi
  limits:
    cpu: 100m
    memory: 128Mi

Pull Request: #514

We cannot add another header in the pre-existing resources tab, because this can break CLI.

Anything else you would like to add:
I have already made this change and tested it in an Azure Kubernetes Service cluster with the least possible VM Sku. And the upgradeJob indeed succeeded with the lower resource requirements.

Environment:

  • helm version (use helm version):
  • helm chart version and app version (use helm list -n <YOUR NAMESPACE>):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
@Miraj50
Copy link
Contributor Author

Miraj50 commented Oct 31, 2023

Please feel free to suggest any naming changes.

@jenting jenting added enhancement New feature or request velero labels Nov 1, 2023
@jenting jenting closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request velero
Projects
None yet
Development

No branches or pull requests

2 participants