Setting backupStorageLocation default field to false has no effect

[sherif-fanous]

What steps did you take and what happened:

configuration:
  backupStorageLocation:
    - bucket: <bucket-name>
      config:
        region: us-east-1
        s3ForcePathStyle: true
        s3Url: <s3-endpoint>
      default: false
      name: default
      provider: aws

Using a snippet similar to the above to create a backupStorageLocation that is not the default still results in the backStorageLocation being created with the default field set to true

I believe the issue is because of the usage of with here

Changing this section to the following should fix this issue

{{- if .default }}
default: {{ .default }}
{{- end }}

As a result when default is set to false the default field isn't generated by the helm template and somehow/somewhere it seems Velero is assuming that the default value should be set to true

What did you expect to happen:

The backupStorageLocation is created with default set to false

Environment:

• helm version (use helm version): version.BuildInfo{Version:"v3.14.0", GitCommit:"3fc9f4b2638e76f26739cd77c7017139be81d0ea", GitTreeState:"clean", GoVersion:"go1.21.6"}
• helm chart version and app version (use helm list -n <YOUR NAMESPACE>): 5.3.0
• Kubernetes version (use kubectl version): 1.28.5
• Kubernetes installer & version: k0s
• OS (e.g. from /etc/os-release): Debian GNU/Linux 12 (bookworm)

[qiuming-best]

@sherif-fanous could you provide me the logs of the Velero server pod, I'm trying to figure out the reason

[jenting]

@qiuming-best Do you think we should fix it in hell chart or in Velero code?

[qiuming-best]

I'm not sure why @sherif-fanous could not unset the default BSL. I'll wait for the logs for analysis @jenting