Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data download controller UT #6458

Merged

Conversation

qiuming-best
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@qiuming-best qiuming-best added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 4, 2023
Signed-off-by: Ming Qiu <mqiu@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #6458 (2f667f5) into main (5171ab0) will increase coverage by 0.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6458      +/-   ##
==========================================
+ Coverage   59.46%   60.23%   +0.77%     
==========================================
  Files         229      229              
  Lines       24193    24195       +2     
==========================================
+ Hits        14386    14574     +188     
+ Misses       8803     8614     -189     
- Partials     1004     1007       +3     
Impacted Files Coverage Δ
pkg/controller/data_download_controller.go 77.16% <100.00%> (+54.20%) ⬆️

@qiuming-best qiuming-best merged commit 85c3599 into vmware-tanzu:main Jul 4, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants