Update cppcheck to v2.10.2 (#2999)

Create and push docker image concordbft/concord-bft:0.61 also tagged as concordbft/concord-bft:latest

Author: toly-kournik

.github/workflows/build_and_test.yml

@@ -10,7 +10,7 @@ jobs:
     name: Build
     runs-on: ubuntu-22.04
     container:
-      image: concordbft/concord-bft:0.60
+      image: concordbft/concord-bft:latest
       options: --cap-add=NET_ADMIN
     strategy:
       fail-fast: false

Dockerfile

@@ -7,7 +7,7 @@
 #   For example wget and pip-tools.
 
 ARG CONCORD_BFT_TOOLCHAIN_IMAGE_REPO="concordbft/concord-bft"
-ARG CONCORD_BFT_TOOLCHAIN_IMAGE_TAG="toolchain-0.01"
+ARG CONCORD_BFT_TOOLCHAIN_IMAGE_TAG="toolchain-0.02"
 FROM ${CONCORD_BFT_TOOLCHAIN_IMAGE_REPO}:${CONCORD_BFT_TOOLCHAIN_IMAGE_TAG}
 
 ARG GIT_COMMIT

Makefile

@@ -2,11 +2,11 @@ CONCORD_BFT_DOCKER_REPO?=concordbft/
 
 # Base Toolchain image
 CONCORD_BFT_DOCKER_IMAGE_TOOLCHAIN?=concord-bft
-CONCORD_BFT_DOCKER_IMAGE_TOOLCHAIN_VERSION?=toolchain-0.01
+CONCORD_BFT_DOCKER_IMAGE_TOOLCHAIN_VERSION?=toolchain-0.02
 CONCORD_BFT_DOCKERFILE_TOOLCHAIN?=DockerfileToolchain
 # Release (production) image
 CONCORD_BFT_DOCKER_IMAGE_RELEASE?=concord-bft
-CONCORD_BFT_DOCKER_IMAGE_VERSION_RELEASE?=0.60
+CONCORD_BFT_DOCKER_IMAGE_VERSION_RELEASE?=latest
 CONCORD_BFT_DOCKERFILE_RELEASE?=Dockerfile
 
 # Debug (development) image

install_deps_release.sh

@@ -87,6 +87,8 @@ install_googletest() {
     cmake -DCMAKE_CXX_FLAGS="-std=c++11 -march=x86-64 -mtune=generic" ..
     make -j$(nproc) install
     cd ${HOME} && rm -r googletest
+}
+
 install_rocksdb_lib() {
     cd ${HOME}
     wget ${WGET_FLAGS} \

install_toolchain.sh

@@ -52,16 +52,13 @@ install_cmake() {
 }
 
 install_cppcheck(){
-  cd ${HOME}
-  CPPCHECK_VER="2.8"
-  wget ${WGET_FLAGS} https://sourceforge.net/projects/cppcheck/files/cppcheck/${CPPCHECK_VER}/cppcheck-${CPPCHECK_VER}.tar.gz/download -O ./cppcheck.tar.gz
-  tar -xvzf cppcheck.tar.gz && rm ./cppcheck.tar.gz
-  cd cppcheck-${CPPCHECK_VER}
-  mkdir build && cd build
-  cmake ..
-  cmake --build .
-  make -j$(nproc) install
-  cd ${HOME} && rm -rf cppcheck-${CPPCHECK_VER}
+	  cd ${HOME}
+	  git clone -b 2.10.2 https://github.com/danmar/cppcheck.git
+	  cd cppcheck && mkdir build && cd build
+	  cmake ..
+	  make -j$(proc)
+	  make install
+	  cd ${HOME} && rm -rf cppcheck
 }
 
 install_ccache(){