-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpss window in Spectrogram class uses wrong value for NW #91
Labels
BUG: a bug
something isn't working
Comments
NickleDave
added a commit
that referenced
this issue
Apr 9, 2021
note that this merely fixes an AttributeError, `AttributeError: module 'scipy.signal' has no attribute 'slepian'` There's a deeper issue with whether I'm calling `dpss` with the right values, see #91
NickleDave
added a commit
that referenced
this issue
Apr 9, 2021
note that this merely fixes an AttributeError, `AttributeError: module 'scipy.signal' has no attribute 'slepian'` There's a deeper issue with whether I'm calling `dpss` with the right values, see #91
NickleDave
added a commit
that referenced
this issue
Apr 10, 2021
note that this merely fixes an AttributeError, `AttributeError: module 'scipy.signal' has no attribute 'slepian'` There's a deeper issue with whether I'm calling `dpss` with the right values, see #91
NickleDave
added a commit
that referenced
this issue
Apr 10, 2021
note that this merely fixes an AttributeError, `AttributeError: module 'scipy.signal' has no attribute 'slepian'` There's a deeper issue with whether I'm calling `dpss` with the right values, see #91
NickleDave
added a commit
that referenced
this issue
Apr 10, 2021
note that this merely fixes an AttributeError, `AttributeError: module 'scipy.signal' has no attribute 'slepian'` There's a deeper issue with whether I'm calling `dpss` with the right values, see #91
NickleDave
added a commit
that referenced
this issue
Apr 10, 2021
note that this merely fixes an AttributeError, `AttributeError: module 'scipy.signal' has no attribute 'slepian'` There's a deeper issue with whether I'm calling `dpss` with the right values, see #91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the
Spectrogram
class inaudiofileIO
allows the user to specify awindow
, which can be one of `{None, 'Hamm', 'dpss'}.The
dpss
option is supposed to reproduce the behavior from Koumura Okanoya 2016in fixing issues caused by updating to newer versions, I noticed that the
slepian
function I used is now deprecated. It also seems there were some bugs in the implementation, see scipy/scipy#4354which makes me think I was never really generating this taper the right way, anyway
to truly fix this, I need to figure out what the right value for
NW
should be, the standardized half-bandwidth.Not clear to me if
W
parameter that Koumura Okanoya 2016 is the full bandwidth, think I would need to actually look at the textbook they cite (also cited now by thescipy.signal.windows.dpss
docs).Matlab docs give slightly more detailed equations for how they are related:
https://www.mathworks.com/help/signal/ref/dpss.html
for now, just to prevent crash on import, I am going to change to the replacement
dpss
functionIt's probably the case that neither I or anyone else is using this window anyway
but strictly speaking it's using the wrong value and should be fixed
The text was updated successfully, but these errors were encountered: