Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run regression test on systems with high-dpi monitors #1

Open
ftilde opened this issue Oct 29, 2024 · 0 comments
Open

Cannot run regression test on systems with high-dpi monitors #1

ftilde opened this issue Oct 29, 2024 · 0 comments

Comments

@ftilde
Copy link
Contributor

ftilde commented Oct 29, 2024

When running on a system with a devicePixelRatio of for example 2, all screenshots will be double the expected size in each dimension. This is because the screenshot dimensions are equivalent to the physical canvas size, while the window size saved in the workspace corresponds to the logical canvas size.

I don't really know what to do here. I don't think we want to reduce the screenshot size on high-dpi screens by default. That would certainly be unexpected for the user (and I suspect that this might be quite hairy to implement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant