-
Notifications
You must be signed in to change notification settings - Fork 1
Anbit/guidance #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anbit-adhi
wants to merge
3
commits into
main
Choose a base branch
from
anbit/guidance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Anbit/guidance #33
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # Goal | ||
| geometry_msgs/PointStamped goal | ||
| # vortex_msgs/LosActiveMethod method | ||
|
|
||
| --- | ||
| # Result | ||
|
|
||
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| latest_list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| list_2025-11-12_15-03-37 |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. log should be added to .gitignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| [0.087s] DEBUG:colcon:Command line arguments: ['/usr/bin/colcon', 'list', '-p', '--base-paths', '/home/anbitadhi/ros2_ws/src/vortex-msgs', '--log-base', '/dev/null'] | ||
| [0.087s] DEBUG:colcon:Parsed command line arguments: Namespace(log_base=None, log_level=None, verb_name='list', build_base='build', ignore_user_meta=False, metas=['./colcon.meta'], base_paths=['/home/anbitadhi/ros2_ws/src/vortex-msgs', '--log-base', '/dev/null'], packages_ignore=None, packages_ignore_regex=None, paths=None, packages_up_to=None, packages_up_to_regex=None, packages_above=None, packages_above_and_dependencies=None, packages_above_depth=None, packages_select_by_dep=None, packages_skip_by_dep=None, packages_skip_up_to=None, packages_select_build_failed=False, packages_skip_build_finished=False, packages_select_test_failures=False, packages_skip_test_passed=False, packages_select=None, packages_skip=None, packages_select_regex=None, packages_skip_regex=None, packages_start=None, packages_end=None, allow_overriding=[], topological_order=False, names_only=False, paths_only=True, topological_graph=False, topological_graph_dot=False, topological_graph_density=False, topological_graph_legend=False, topological_graph_dot_cluster=False, topological_graph_dot_include_skipped=False, verb_parser=<colcon_defaults.argument_parser.defaults.DefaultArgumentsDecorator object at 0xfc4b8108a380>, verb_extension=<colcon_package_information.verb.list.ListVerb object at 0xfc4b81089480>, main=<bound method ListVerb.main of <colcon_package_information.verb.list.ListVerb object at 0xfc4b81089480>>) | ||
| [0.199s] Level 1:colcon.colcon_core.package_discovery:discover_packages(colcon_meta) check parameters | ||
| [0.199s] Level 1:colcon.colcon_core.package_discovery:discover_packages(recursive) check parameters | ||
| [0.199s] Level 1:colcon.colcon_core.package_discovery:discover_packages(ignore) check parameters | ||
| [0.199s] Level 1:colcon.colcon_core.package_discovery:discover_packages(path) check parameters | ||
| [0.199s] Level 1:colcon.colcon_core.package_discovery:discover_packages(recursive) discover | ||
| [0.199s] INFO:colcon.colcon_core.package_discovery:Crawling recursively for packages in '/home/anbitadhi/ros2_ws/src/vortex-msgs', '/home/anbitadhi/ros2_ws/src/vortex-msgs/--log-base', '/dev/null' | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extensions ['ignore', 'ignore_ament_install'] | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extension 'ignore' | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extension 'ignore_ament_install' | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extensions ['colcon_pkg'] | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extension 'colcon_pkg' | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extensions ['colcon_meta'] | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extension 'colcon_meta' | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extensions ['ros'] | ||
| [0.199s] Level 1:colcon.colcon_core.package_identification:_identify(/home/anbitadhi/ros2_ws/src/vortex-msgs) by extension 'ros' | ||
| [0.211s] DEBUG:colcon.colcon_core.package_identification:Package '/home/anbitadhi/ros2_ws/src/vortex-msgs' with type 'ros.ament_cmake' and name 'vortex_msgs' | ||
| [0.211s] Level 1:colcon.colcon_core.package_discovery:discover_packages(recursive) using defaults |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #request | ||
| int8 mode # 0=PROPORTIONAL, 1=INTEGRAL, 2=ADAPTIVE | ||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest something like this # request
uint8 PROPORTIONAL=0
uint8 INTEGRAL=1
uint8 ADAPTIVE=2
uint8 mode
---
# response
bool success |
||
| --- | ||
| #response | ||
| bool success | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to just remove it if it is not in use