Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All examples do not launch #18

Open
kdemarest opened this issue Apr 28, 2020 · 1 comment
Open

All examples do not launch #18

kdemarest opened this issue Apr 28, 2020 · 1 comment

Comments

@kdemarest
Copy link

Clicking examples does nothing and does not throw an error, on the page:
http://www.voxeljs.com/#gallery

In: Chrome latest Version 81.0.4044.122 (Official Build) (64-bit)
On: Mac OS 10.15.4 (Catalina), Macbook Air 13 inch 2015 with Intel HD Graphics 6000 1536 MB

To be clear, WebGL is supported on the machine and works fine.

I debugged for a little bit, but it wasn't obvious. One strange thing is that all of the tags say "view source on github" but only some of them have an actual link that leads anywhere.

@kdemarest
Copy link
Author

kdemarest commented Apr 28, 2020

I think I see it. Did you deploy an old version by accident?

All examples on the actual, live website have had the <a href> stripped out. For example, here is what is actually begin served:

<div class="exampleItem">
        <img src="demos/1.png">
        <cite>view source on github</cite>
      </div>

But here is what the github source code for the site says:

<div class="exampleItem">
        <a href="http://gifblocks.com/" target="_blank"><img src="demos/1.png"></a>
        <cite><a href="https://github.com/maxogden/gifblocks/blob/gh-pages/demo.js" target="_blank">view source on github</a></cite>
      </div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant