Skip to content

DNS lookups freeze up the entire application  #17

@untodesu

Description

@untodesu

Description

Whenever enet_address_set_host is called, it performs a DNS lookup, and sometimes (🤡🤡🤡 Roskomnadzor 🤡🤡🤡) lookups take a noticeably long time to finish and because the function is blocking by definition, it locks up the game.

Steps to reproduce

  1. Literally exist
  2. Enter an IP address into a server browser
  3. Click refresh a bunch of times
  4. Observe the frozen game

Expected behaviour

The game not passing out

Screenshots (optional)

Environment

  • Binary source: any
  • Operating system: any
  • Game version: 15.x.x and older, 16.0.1

Additional context

It has been fixed in Prospero by moving DNS lookups into a coroutine. Might as well do that here and cache the result?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions