Puppet removes plugin when plugin was installed using the Jenkins ui

[GMZwinge]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7.23.0
• Ruby: 2.7.7p221
• Distribution: not sure what this is referring to
• Module version: 2.0.1-rc0 (f786482, 5/5/2022 11:21:15 AM)
• Jenkins: 2.355

How to reproduce (e.g Puppet code you use)

• Use Jenkins UI to install a plugin, eg: pipeline-build-step and pipeline-milestone-step. This installs the plugin jpi file.
• Use puppet-jenkins to install the same plugin version.

What are you seeing

• The Jenkins UI shows the plugin as available, but not installed.
• The plugins folder only contains the folder for the plugin, not the plugin hpi nor jpi file.

What behaviour did you expect instead

• The Jenkins UI should show the plugin as installed.
• The plugins folder should contain the plugin hpi file and the folder for the plugin.

Output log

• Puppet output shows that the plugin jpi file is removed and that the plugin hpi file is not installed.

Any additional information you'd like to impart

• The root cause may be that

  puppet-jenkins/lib/puppet/jenkins/plugins.rb

  Line 45 in 2fa686c

  def self.available

  seems to return the list of plugins that have a subfolder in the plugins folder with a MANIFEST.MF file, but does not check if the hpi or jpi file is present.
• A workaround is to add in

  puppet-jenkins/manifests/plugin.pp

  Line 202 in 2fa686c

  $archive_require = undef

  the archive of the plugin like in

  puppet-jenkins/manifests/plugin.pp

  Line 188 in 2fa686c

  -> archive { $plugin:

  A better fix may be to update

  puppet-jenkins/lib/puppet/jenkins/plugins.rb

  Line 45 in 2fa686c

  def self.available

  to check for existence of the hpi or jpi file.
• It probably still happens with the latest voxpupuli/puppet-jenkins, as I don’t see any major changes in the above two files related to this issue.