Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup failing tests #401

Closed
h-haaks opened this issue Oct 14, 2020 · 1 comment
Closed

Cleanup failing tests #401

h-haaks opened this issue Oct 14, 2020 · 1 comment

Comments

@h-haaks
Copy link
Contributor

h-haaks commented Oct 14, 2020

Hi,

I have been using some days now to try to fix all testing issues in the module.
To do this I started out by converting the module to PDK 1.18.1.
I have done my best to map existing setup, but there is some major changes.

I had to skip some acceptance tests in the plugin class for versions >= 6.7 because there have been a change
in the logstash-plugin command.
This command changed in two ways as I can see.
1: it now has to be run from the logstash homedir
2: new option --installed is needed to list only installed plugins

To solve this we either have to drop support for versions < 6.7, or implement a fact that hold the installed logstash version.

Please let me know what you think of my changes..
I really need this module back on track with java 11+ and logstash 7.

@h-haaks
Copy link
Contributor Author

h-haaks commented Dec 29, 2022

Resolved by #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants