refacto: make EvalContext mutable in modules

The memory object will be mutable in it. Make this change now to avoid
polluting the diff of the next commit.

Author: vthib

boreal/src/compiler/module.rs

@@ -50,7 +50,7 @@ pub enum ModuleExpressionKind {
     /// A value coming from a function exposed by a module.
     StaticFunction {
         /// The function to call.
-        fun: fn(&EvalContext, Vec<Value>) -> Option<Value>,
+        fun: fn(&mut EvalContext, Vec<Value>) -> Option<Value>,
     },
 }
 
@@ -622,7 +622,7 @@ mod tests {
     use crate::test_helpers::test_type_traits_non_clonable;
 
     #[cfg_attr(coverage_nightly, coverage(off))]
-    fn test_fun(_ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn test_fun(_ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         drop(args);
         None
     }

boreal/src/evaluator/module.rs

@@ -102,12 +102,12 @@ pub(super) fn evaluate_expr(
                 .take(*nb_arguments)
                 .map(expr_value_to_module_value)
                 .collect();
-            let eval_ctx = EvalContext {
+            let mut eval_ctx = EvalContext {
                 mem: &evaluator.scan_data.mem,
                 module_data: &evaluator.scan_data.module_values.data_map,
                 process_memory: evaluator.scan_data.params.process_memory,
             };
-            let value = fun(&eval_ctx, arguments).ok_or(PoisonKind::Undefined)?;
+            let value = fun(&mut eval_ctx, arguments).ok_or(PoisonKind::Undefined)?;
             evaluate_ops(evaluator, &value, ops, expressions)
         }
     }
@@ -153,12 +153,12 @@ fn evaluate_ops(
                         .take(*nb_arguments)
                         .map(expr_value_to_module_value)
                         .collect();
-                    let eval_ctx = EvalContext {
+                    let mut eval_ctx = EvalContext {
                         mem: &evaluator.scan_data.mem,
                         module_data: &evaluator.scan_data.module_values.data_map,
                         process_memory: evaluator.scan_data.params.process_memory,
                     };
-                    let new_value = fun(&eval_ctx, arguments).ok_or(PoisonKind::Undefined)?;
+                    let new_value = fun(&mut eval_ctx, arguments).ok_or(PoisonKind::Undefined)?;
                     // Avoid cloning the value if possible
                     return if operations.peek().is_none() {
                         Ok(new_value)

boreal/src/module/elf.rs

@@ -568,7 +568,7 @@ fn get_symbols<Elf: FileHeader>(
 
 impl Elf {
     #[cfg(feature = "hash")]
-    fn import_md5(ctx: &EvalContext, _: Vec<Value>) -> Option<Value> {
+    fn import_md5(ctx: &mut EvalContext, _: Vec<Value>) -> Option<Value> {
         use md5::{Digest, Md5};
 
         let data = ctx.module_data.get::<Self>()?;
@@ -581,7 +581,7 @@ impl Elf {
     }
 
     #[cfg(feature = "hash")]
-    fn telfhash(ctx: &EvalContext, _: Vec<Value>) -> Option<Value> {
+    fn telfhash(ctx: &mut EvalContext, _: Vec<Value>) -> Option<Value> {
         const EXCLUDED_STRINGS: &[&[u8]; 8] = &[
             b"__libc_start_main",
             b"main",

boreal/src/module/hash.rs

@@ -87,7 +87,7 @@ fn compute_hash<D: Digest>(bytes: &[u8]) -> Value {
 }
 
 impl Hash {
-    fn md5(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn md5(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         match get_args(args)? {
             Args::Bytes(s) => Some(compute_hash::<Md5>(&s)),
             Args::Range(offset, end) => {
@@ -111,7 +111,7 @@ impl Hash {
         }
     }
 
-    fn sha1(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn sha1(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         match get_args(args)? {
             Args::Bytes(s) => Some(compute_hash::<Sha1>(&s)),
             Args::Range(offset, end) => {
@@ -135,7 +135,7 @@ impl Hash {
         }
     }
 
-    fn sha2(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn sha2(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         match get_args(args)? {
             Args::Bytes(s) => Some(compute_hash::<Sha256>(&s)),
             Args::Range(offset, end) => {
@@ -159,7 +159,7 @@ impl Hash {
         }
     }
 
-    fn checksum32(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn checksum32(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         apply(ctx, args, |s| {
             let checksum = s
                 .iter()
@@ -168,7 +168,7 @@ impl Hash {
         })
     }
 
-    fn crc32(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn crc32(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         apply(ctx, args, |s| {
             let crc = crc32fast::hash(s);
             Value::Integer(i64::from(crc))
@@ -201,7 +201,7 @@ fn get_args(args: Vec<Value>) -> Option<Args> {
     }
 }
 
-fn apply<F>(ctx: &EvalContext, args: Vec<Value>, fun: F) -> Option<Value>
+fn apply<F>(ctx: &mut EvalContext, args: Vec<Value>, fun: F) -> Option<Value>
 where
     F: FnOnce(&[u8]) -> Value,
 {

boreal/src/module/macho.rs

@@ -721,7 +721,7 @@ impl ModuleData for MachO {
 }
 
 impl MachO {
-    fn file_index_for_arch(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn file_index_for_arch(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         let mut args = args.into_iter();
         let v1: i64 = args.next()?.try_into().ok()?;
         let v2 = args.next().and_then(|v| i64::try_from(v).ok());
@@ -742,7 +742,7 @@ impl MachO {
         None
     }
 
-    fn entry_point_for_arch(ctx: &EvalContext, args: Vec<Value>) -> Option<Value> {
+    fn entry_point_for_arch(ctx: &mut EvalContext, args: Vec<Value>) -> Option<Value> {
         let mut args = args.into_iter();
         let v1: i64 = args.next()?.try_into().ok()?;
         let v2 = args.next().and_then(|v| i64::try_from(v).ok());