Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

Slack's WebSocket API requires lowercase "websocket" in the Upgrade header #65

Open
afresh1 opened this issue Jan 12, 2021 · 2 comments

Comments

@afresh1
Copy link

afresh1 commented Jan 12, 2021

As described in a ticket for the Python Slack RTM client, although RFC 6455 says:

  1. An |Upgrade| header field containing the value "websocket",
    treated as an ASCII case-insensitive value.

Slack has decided to be more particular. I don't know whether we should adjust this, but the RFC does use lowercase "websocket" in its examples, so it seems likely that other folks will get this wrong.

@vti
Copy link
Owner

vti commented Jan 13, 2021

Maybe making it configurable is an option. It's unfortunate that because of some "big tech" decisions or bugs we have to change totally valid code.

@afresh1
Copy link
Author

afresh1 commented Jan 13, 2021

It is incredibly annoying. I would much prefer they just fixed it.

vti pushed a commit that referenced this issue Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants