-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autofix to define-props-declaration
: transform runtime syntax to type-based syntax
#2465
Comments
PR welcome, but note that the autofix would need to handle quite complex cases like transforming |
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) handle native types (String, Boolean etc.)
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) handle PropTypes (e.g. String as PropType<'test'>)
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) handle required option
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) handle default option
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) handle separateInterface rule option
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) bring back the runtime check
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) additional tests and refactoring
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) documentation update
Pull request created #2466 |
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 27, 2024
…ased syntax (vuejs#2465) fix tests failing on some environments
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 28, 2024
…ased syntax (vuejs#2465) handle array of types
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 28, 2024
…ased syntax (vuejs#2465) refactoring
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 28, 2024
…ased syntax (vuejs#2465) copy type for unknown expressions, ignore fixing cases when error is thrown
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
May 28, 2024
…ased syntax (vuejs#2465) handle union type
Was thinking about this transform for this rule when upgrading large project from previous minor Vue version. |
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
Jul 15, 2024
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
Jul 26, 2024
mpiniarski
added a commit
to mpiniarski/eslint-plugin-vue
that referenced
this issue
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What rule do you want to change?
define-props-declaration
Does this change cause the rule to produce more or fewer warnings?
Does not change the number of warnings.
How will the change be implemented? (New option, new default behavior, etc.)?
Implementing a
fix
method in thecontext.report
descriptor
parameter.The rule will support
separateInterface
option that will opt-in to define type passed to thedefineProps
as an interface abovedefineProps
call.Please provide some example code that this change will affect:
The rule will be able to autofix the following code:
transforming it to:
What does the rule currently do for this code?
It des not fix it.
What will the rule do after it's changed?
The rule will have the autofix feature transforming runtime syntax to type-based syntax
Additional context
The text was updated successfully, but these errors were encountered: