Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect RPCs with 2FA #19

Open
altafan opened this issue Sep 12, 2022 · 3 comments
Open

Protect RPCs with 2FA #19

altafan opened this issue Sep 12, 2022 · 3 comments

Comments

@altafan
Copy link
Collaborator

altafan commented Sep 12, 2022

Let's add a password_hash string field to Transfer request message in order to protect this endpoint in such a sensitive operation.

@tiero
Copy link
Member

tiero commented Sep 12, 2022

For Ocean instead it may be interesting to move to 2fa/topt server as definitive solution.

Also some user may and other may not want it, so it should be enabled at will and maybe for all and specific RPCs

@altafan
Copy link
Collaborator Author

altafan commented Sep 14, 2022

Not sure if requiring 2fa for generating a receiving address is a feature from user POV.

Tipically, wallets protect with 2fa the login, the transfer of funds and eventually some settings operation like changing the password for example. We could start by protecting these 3 RPCs initally.

@tiero
Copy link
Member

tiero commented Sep 14, 2022

Yes agreed, but my point was that if we have a whitelist/blacklist system to filter out RPCs would be easier to add/remove the protected route at will

@altafan altafan changed the title Protect Transfer rpc with password Protect RPCs with 2FA Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants