-
Notifications
You must be signed in to change notification settings - Fork 394
vpp: T7972: Improve nat44 no-forwarding feature name and description in CLI
#4880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
natali-rs1985
wants to merge
1
commit into
vyos:current
Choose a base branch
from
natali-rs1985:T7972
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
sever-sever
reviewed
Nov 28, 2025
sever-sever
reviewed
Nov 28, 2025
sever-sever
reviewed
Nov 28, 2025
1 task
Contributor
Author
|
@sever-sever All change requests were addressed |
|
CI integration 👍 passed! Details
|
sever-sever
approved these changes
Dec 1, 2025
Member
sever-sever
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my requests have been fulfilled.
Migrate NAT no-forwarding option to more clear CLI syntax/meaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CLI command for nat44 no-forwarding:
Change summary
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-documentation#1717
How to test / Smoketest result
Checklist: