-
Notifications
You must be signed in to change notification settings - Fork 381
Proofread docs in the /operation directory #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Proofread docs in the /operation directory #1710
Conversation
operation directory
operation directory| recent Linux distributions. | ||
|
|
||
| For additional details you can refer to https://vyos.dev/T2490. | ||
| For details, see https://vyos.dev/T2490. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue was resolved in 2020. Is the above content still relevant?
| .. note:: If a device is unplugged and re-plugged it will receive a new | ||
| Port, Dev, If identification. | ||
| .. note:: If a device is unplugged and plugged in again, it is assigned a new | ||
| ``Port``, ``Dev``, and ``If``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do Dev and If stand for?
| ################# | ||
|
|
||
| Using the console, restart the VyOS router. The GRUB menu appears. | ||
| Select the relevant option from the GRUB menu and press Enter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this password recovery flow still accurate?
| Standard installation on a single disk | ||
| ------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be
Standard installation on a single disk
--------------------------------------
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR proofreads and improves documentation in the /docs/operation directory to align with the Microsoft Writing Style Guide. The changes focus on improving clarity, consistency, and readability across five operation documentation files while updating the last proofread dates to November 2025.
- Standardized UI element formatting using bold text (e.g., Yes, No, Enter)
- Improved sentence structure and readability throughout the documentation
- Updated terminology for consistency (e.g., "RAID-1" to "RAID 1")
- Enhanced descriptions with clearer, more concise language
- Added proper section cross-references and updated metadata
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
docs/operation/upgrade-recovery.rst |
Improved readability of upgrade recovery feature documentation, clarified timeout behavior, and wrapped long lines for better formatting |
docs/operation/raid.rst |
Extensive revisions to RAID 1 documentation including terminology standardization, UI element formatting, section header updates, and improved procedural instructions |
docs/operation/password-recovery.rst |
Minor improvements to password recovery instructions with updated UI element formatting and clearer action descriptions |
docs/operation/information.rst |
Enhanced system information command documentation with updated examples, improved USB device descriptions, and added VyOS 1.5 release train information |
docs/operation/boot-options.rst |
Simplified boot option instructions with clearer warnings and more concise procedural steps |
docs/_locale/{uk,pt,ja,es,de}/operation.pot |
Updated translation files to reflect changes in UI element formatting from quoted text to bold text |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| VyOS provides several kernel command-line options to modify the normal boot | ||
| process. | ||
| To add an option, select the desired image in the GRUB menu at load time. | ||
| Type **e** to edit the first line, then type **Ctrl+x** to boot. |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent keyboard key notation. Line 17 uses "Ctrl+x" with a plus sign, but this is inconsistent with standard documentation practices. The Microsoft Writing Style Guide recommends using "Ctrl+X" (with capital X) for keyboard shortcuts. Additionally, verify consistency with other keyboard notations in the document (line 17 uses "e" which should also be consistent).
| Type **e** to edit the first line, then type **Ctrl+x** to boot. | |
| Type **e** to edit the first line, then type **Ctrl+X** to boot. |
|
|
||
| Installation Implications | ||
| Installation implications | ||
| ========================= |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent section header capitalization. According to the Microsoft Writing Style Guide, sentence-style capitalization should be used for headings. Change "Installation implications" to match the capitalization style used in other section headers like "Configuration".
| ========================= | |
| ======================== |
| ============= | ||
|
|
||
| Single disk, install as normal | ||
| Standard installation on a single disk |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent section header capitalization. The header should use title case for consistency with other sections. Change "Standard installation on a single disk" to "Standard Installation on a Single Disk".
| Standard installation on a single disk | |
| Standard Installation on a Single Disk |
| * If you do not want to configure RAID 1 mirroring, enter **No** at the prompt. | ||
|
|
||
| Empty 2+ Disk | ||
| Empty 2+ disk |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent section header capitalization. The header should use title case for consistency with other sections. Change "Empty 2+ disk" to "Empty 2+ Disk" to match the capitalization style.
| Empty 2+ disk | |
| Empty 2+ Disk |
|
|
||
|
|
||
| Present RAID-1 | ||
| Preexisting RAID 1 configuration |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent section header capitalization. The header should use title case for consistency with other sections. Change "Preexisting RAID 1 configuration" to "Preexisting RAID 1 Configuration".
| Preexisting RAID 1 configuration | |
| Preexisting RAID 1 Configuration |
| 4. Enter **Yes** at the prompt to retain the current VyOS configuration | ||
| Enter **No** to delete the current VyOS configuration. |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence structure is awkward and incomplete. Line 90 starts a new sentence but doesn't complete the thought clearly. Consider revising to: "4. Enter Yes at the prompt to retain the current VyOS configuration, or enter No to delete the current VyOS configuration."
| 4. Enter **Yes** at the prompt to retain the current VyOS configuration | |
| Enter **No** to delete the current VyOS configuration. | |
| 4. Enter **Yes** at the prompt to retain the current VyOS configuration, or enter **No** to delete the current VyOS configuration. |
| where ``RAID-1-device`` is the name of the RAID 1 device. For example, | ||
| ``md0`` and | ||
| ``disk-partition`` is the name of the failed disk partition. For example, | ||
| ``sdb2``. |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awkward line break. The text "For example, md0 and" should continue on the same line as the description. Consider reformatting to: "where RAID-1-device is the name of the RAID 1 device (for example, md0) and disk-partition is the name of the failed disk partition (for example, sdb2)."
| where ``RAID-1-device`` is the name of the RAID 1 device. For example, | |
| ``md0`` and | |
| ``disk-partition`` is the name of the failed disk partition. For example, | |
| ``sdb2``. | |
| where ``RAID-1-device`` is the name of the RAID 1 device (for example, ``md0``) and ``disk-partition`` is the name of the failed disk partition (for example, ``sdb2``). |
| where ``RAID-1-device`` is the name of the RAID 1 device. For example, | ||
| ``md0`` and | ||
| ``disk-partition`` is the name of the replacement disk partition. | ||
| For example, ``sdb2``. |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awkward line break. The formatting is inconsistent with examples spread across multiple lines. Consider reformatting to: "where RAID-1-device is the name of the RAID 1 device (for example, md0) and disk-partition is the name of the replacement disk partition (for example, sdb2)."
| where ``RAID-1-device`` is the name of the RAID 1 device. For example, | |
| ``md0`` and | |
| ``disk-partition`` is the name of the replacement disk partition. | |
| For example, ``sdb2``. | |
| where ``RAID-1-device`` is the name of the RAID 1 device (for example, ``md0``) and ``disk-partition`` is the name of the replacement disk partition (for example, ``sdb2``). |
| In the past, serial interfaces were defined as ``ttySx`` and ``ttyUSBx`` where | ||
| ``x`` | ||
| was the instance number. However, the mapping of USB-based serial interfaces |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Awkward line break in the middle of a sentence. Line 23 breaks at "x" which creates a confusing read. Consider keeping "where x was the instance number" on the same line for better readability.
| In the past, serial interfaces were defined as ``ttySx`` and ``ttyUSBx`` where | |
| ``x`` | |
| was the instance number. However, the mapping of USB-based serial interfaces | |
| In the past, serial interfaces were defined as ``ttySx`` and ``ttyUSBx`` where ``x`` was the instance number. However, the mapping of USB-based serial interfaces |
| interface is now directly identified by the USB root bridge and bus it connects | ||
| to. This somehow mimics the new network interface definitions we see in recent | ||
| Linux distributions. | ||
| To address this issue, and because of many low-cost USB-to-serial converters |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar issue: "because of many" should be "because many". Remove "of" for correct grammar.
| To address this issue, and because of many low-cost USB-to-serial converters | |
| To address this issue, and because many low-cost USB-to-serial converters |
Change Summary
Edited content in the
docs/operationdirectory to align with the Microsoft Writing Style Guideboot-options.rstinformation.rstupgrade-recovery.rstraid.rstpassword-recovery.rstRelated Task(s)
Related PR(s)
Backport
Checklist: