Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: clean up performance issues in tests #3836

Open
charles-cooper opened this issue Mar 6, 2024 · 1 comment
Open

chores: clean up performance issues in tests #3836

charles-cooper opened this issue Mar 6, 2024 · 1 comment

Comments

@charles-cooper
Copy link
Member

Version Information

  • vyper Version (output of vyper --version): v0.4.0b2

What's your issue about?

laundry list of performance issues in test suite

  • overuse of pytest parametrize (particularly in test_convert.py) results in spending a lot of time in test collection
  • eth-tester has inefficient shims, we could modify VyperContract (in conftest.py) to use a different backend
    • we could get rid of get_contract_with_gas_estimation (and either get rid of the gas check entirely or apply it to get_contract so it runs for all tests)
@charles-cooper
Copy link
Member Author

mostly complete in #3846. there are still some things in test collection we can optimize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant