Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Release Actions" doesn't yet use the queuing mechanism for actions #1837

Open
whimboo opened this issue Sep 5, 2024 · 1 comment · May be fixed by #1853
Open

"Release Actions" doesn't yet use the queuing mechanism for actions #1837

whimboo opened this issue Sep 5, 2024 · 1 comment · May be fixed by #1853

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 5, 2024

While implementing the queuing mechanism for Actions in our WebDriver BiDi code base for Firefox I noticed that for the Release Actions command we are just trying to run tick actions, but do not queue this up as a task. That means running a Release Actions command in parallel to the Perform Actions command in BiDi will immediately trigger the release of inputs which in most cases will be a no-op and later on will not reset the inputs unless the browsing context (navigable) gets closed or Release Actions is called again.

I'm going to add a wdspec test for both commands as part of my work on https://bugzilla.mozilla.org/show_bug.cgi?id=1915798.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 5, 2024

Also the retrieval of the undo actions in Release Actions need to happen within the queued task. Otherwise there might be nothing to undo for the release action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant