From 9ada0d1516d12fd31b08d4764c6ef1853e31192f Mon Sep 17 00:00:00 2001
From: Florent Castelli <florent.castelli@gmail.com>
Date: Mon, 27 Mar 2023 18:02:55 +0200
Subject: [PATCH] Add a codec match algorithm for setCodecPreferences

Also remove impossible to implement steps in setCodecPreferences,
as it's always possible to modify a dictionary.

Fixes #2845.
---
 amendments.json |  9 +++++++++
 webrtc.html     | 52 +++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 51 insertions(+), 10 deletions(-)

diff --git a/amendments.json b/amendments.json
index 0fca23066..0d8f16ead 100644
--- a/amendments.json
+++ b/amendments.json
@@ -440,5 +440,14 @@
       "status": "candidate",
       "id": 30
     }
+  ],
+  "setcodecparameters-algorithm": [
+    {
+      "description": "Fix ambiguities in the setCodecPreferences() algorithm",
+      "pr": 2847,
+      "type": "correction",
+      "status": "candidate",
+      "id": 31
+    }
   ]
 }
diff --git a/webrtc.html b/webrtc.html
index fee0e333b..73791dfd0 100644
--- a/webrtc.html
+++ b/webrtc.html
@@ -11109,18 +11109,13 @@ <h2>
                   be removed from the mapping of payload types in the SDP.
                 </p>
                 <p>
-                  The <var>codecs</var> sequence passed into
-                  {{setCodecPreferences}} can only contain codecs that are
-                  returned by
+                  {{setCodecPreferences}} will reject attempts to set <var>codecs</var>
+                  [=not matching | codec match=] codecs found in
                   {{RTCRtpSender}}.{{RTCRtpSender/getCapabilities}}(<var>kind</var>)
                   or
                   {{RTCRtpReceiver}}.{{RTCRtpReceiver/getCapabilities}}(<var>kind</var>),
                   where <var>kind</var> is the kind of the
                   {{RTCRtpTransceiver}} on which the method is called.
-                  Additionally, the {{RTCRtpCodecCapability}} dictionary
-                  members cannot be modified. If <var>codecs</var> does not
-                  fulfill these requirements, the user agent MUST [=
-                  exception/throw =] an {{InvalidModificationError}}.
                 </p>
                 <p class="note">
                   Due to a recommendation in [[!SDP]], calls to
@@ -11196,9 +11191,10 @@ <h2>
                       For each <var>codec</var> in <var>codecs</var>,
                     </p>
                     <ol>
-                      <li>If <var>codec</var> is not in
-                      <var>codecCapabilities</var>, throw
-                      {{InvalidModificationError}}.
+                      <li>
+                        <p>If <var>codec</var> does [=not match any codec|codec match=]
+                          in <var>codecCapabilities</var>, throw {{InvalidModificationError}}.
+                        </p>
                       </li>
                     </ol>
                   </li>
@@ -11209,6 +11205,42 @@ <h2>
                     </p>
                   </li>
                 </ol>
+                <p>
+                  The <dfn class="export">codec match</dfn> algorithm given two {{RTCRtpCodec}} or compatible dictionaries <var>first</var> and <var>second</var> is as follows:
+                </p>
+                <ol class=algorithm>
+                  <li>
+                    <p>
+                      If <var>first</var>.{{RTCRtpCodec/mimeType}} is different from
+                      <var>second</var>.{{RTCRtpCodec/mimeType}}, return <code>false</code>.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      If <var>first</var>.{{RTCRtpCodec/clockRate}} is different from
+                      <var>second</var>.{{RTCRtpCodec/clockRate}}, return <code>false</code>.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      If either (but not both) of <var>first</var>.{{RTCRtpCodec/channels}} and <var>second</var>.{{RTCRtpCodec/channels}}
+                      are  missing, or if they are both present and <var>first</var>.{{RTCRtpCodec/channels}} is different from
+                      <var>second</var>.{{RTCRtpCodec/channels}}, return <code>false</code>.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      If either (but not both) of <var>first</var>.{{RTCRtpCodec/sdpFmtpLine}} and <var>second</var>.{{RTCRtpCodec/sdpFmtpLine}}
+                      are  missing, or if they are both present and <var>first</var>.{{RTCRtpCodec/sdpFmtpLine}} is different from
+                      <var>second</var>.{{RTCRtpCodec/sdpFmtpLine}}, return <code>false</code>.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      Return <code>true</code>.
+                    </p>
+                  </li>
+                </ol>
                 <p class="note">
                   If set, the offerer's codec preferences will decide the order
                   of the codecs in the offer. If the answerer does not have any