Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR Device API (delta/aiming 2nd CRS) #983

Closed
1 task done
himorin opened this issue Aug 21, 2024 · 1 comment
Closed
1 task done

WebXR Device API (delta/aiming 2nd CRS) #983

himorin opened this issue Aug 21, 2024 · 1 comment

Comments

@himorin
Copy link

himorin commented Aug 21, 2024

こんにちは TAG-さん!

I'm requesting a TAG review of WebXR Device API.

This specification describes support for accessing virtual reality (VR) and augmented reality (AR) devices, including sensors and head-mounted displays, on the Web.

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: Expecting to update existing CRS, no specific target date
  • The group where the work on this specification is currently being done: Immersive Web WG
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): n/a
  • Major unresolved issues with or opposition to this specification: no
  • This work is being funded by:

You should also know that...

changes from 1st CRS is listed in specification, and we've got TAG review for first one at #782
We'd like to get review over remaining five substantive changes: immersive-web/webxr#1314 immersive-web/webxr#1332 immersive-web/webxr#1343 immersive-web/webxr#1353 immersive-web/webxr#1359

@matatk
Copy link

matatk commented Sep 18, 2024

Thanks for your review request—and for highlighting the changes since last time. Here are a few comments on these changes.

HT @m-alkalbani for assisting with the review.

  1. Expose XRSession’s granted features (GitHub #1296)

    Looks good!

  2. Add support for the isSystemKeyboardSupported attribute (GitHub #1314)

    This Boolean's name starts with 'is' whereas others' names don't seem to. Is there a reason for this, such as consistency with other specs? It seems inconsistent with other parts of WebXR Device API.

  3. Clarify getPose behavior with visibile-blurred (GitHub #1332)

    Looks good!

  4. Transient intent addition (GitHub #1343)

    This looks good — but gave rise to a question about an instance of one of the terms used in the definition of targetRayMode enum values...

    Assuming that the gaze enum variant is talking about getting input from the direction someone's head is facing...

    The definition for the transient-pointer enum variant states: "Some examples are user intents based on information too sensitive to expose directly such as gaze..." — however in this phrase, is "gaze" actually referring to input that comes from eye gaze (i.e. eye tracking)? If so, the word "gaze" is referring to two differnet things; would you be able to re-phrase this to make that clear?

  5. First draft for adding a property to XRInputSource to say it’s visible elsewhere (GitHub #1353)

    This looks good — but the PR referenced here should be 1352, so the Changes section should be updated.

  6. Clarify rgb vs srgb behavior (GitHub #1359)

    We want to keep reminding people to try to align colors between CSS, canvas, and the other drawing surfaces in the platform. That said, that's a long-term project, and we don't expect this incremental change to solve it. Otherwise looks good!

Also...

  1. The definition for transient-pointer has a typo; it mentions "W3C design principals" — I think you mean to reference Web Design Principle 2.9: Don’t reveal that assistive technologies are being used; if so, perhaps you could include this link.

    That you made the reference, and read the principles, is appreciated!

@matatk matatk closed this as completed Sep 18, 2024
@matatk matatk added the Resolution: satisfied The TAG is satisfied with this design label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants