Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Willow and django-modelcluster as locally editable dependencies #4

Open
saevarom opened this issue Jan 29, 2020 · 4 comments · May be fixed by #45
Open

Add Willow and django-modelcluster as locally editable dependencies #4

saevarom opened this issue Jan 29, 2020 · 4 comments · May be fixed by #45

Comments

@saevarom
Copy link
Collaborator

No description provided.

@saevarom
Copy link
Collaborator Author

Willow has been added in commit 7ba9d32

@zerolab
Copy link
Contributor

zerolab commented Jun 20, 2022

I use this with a few other libraries so my Dockerfile looks like:

#...

COPY ./wagtail /code/wagtail/
COPY ./libs /code/libs/

RUN cd /code/wagtail/ \
     && pip install -e .[testing,docs]

RUN cd /code/libs/ \
    && pip install -e wagtail-headless-preview wagtail-localize wagtail-markdown wagtailmedia Willow

# ...

I wonder if there's scope to install everything in /code/libs/ so then anything in there can be picked up automatically without having to edit the Dockerfile

@saevarom
Copy link
Collaborator Author

Yes, I think we should definitely figure out a way to pip install everything in /code/libs.
Probably just a matter of doing some clever shell magic to list the folder names after pip install -e

@saevarom
Copy link
Collaborator Author

I've create a PR which should theoretically allow you to put local versions of dependencies into the libs folder and then the Dockerfile will pick it up and local pip install it. Would be nice if you could try it out some time @zerolab .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants