[sesman] Simplify internal module management

Internal modules loading with sesman was a bit fuzzy.
It is now simplified:
- service should have the name INTERNAL
- target_host field should have the name of the module

Author: mengtan

tools/sesman/sesmanworker/engine.py

@@ -647,17 +647,6 @@ def get_targets_list(self, group_filter: str, device_filter: str, protocol_filte
         for target_info in self.displaytargets:
             temp_service_login = target_info.service_login
             temp_resource_service_protocol_cn = target_info.protocol
-            if target_info.protocol != "APP" \
-                and target_info.target_name in {'autotest',
-                                                'bouncer2',
-                                                'widget2_message',
-                                                'widgettest',
-                                                'card',
-                                               }:
-                temp_service_login = target_info.service_login.replace(
-                    ':RDP',
-                    ':INTERNAL', 1)
-                temp_resource_service_protocol_cn = 'INTERNAL'
 
             if (fc(group_filter) not in fc(target_info.group)
                 or fc(protocol_filter) not in fc(temp_resource_service_protocol_cn)):

tools/sesman/sesmanworker/sesman.py

@@ -72,6 +72,7 @@
 MAGICASK = ('UNLIKELYVALUEMAGICASPICONSTANTS'
             '3141592926ISUSEDTONOTIFYTHEVALUEMUSTBEASKED')
 
+MAGIC_INTERNAL_SERVICE = 'INTERNAL'
 KEEPALIVE_INTERVAL = 30
 KEEPALIVE_GRACEDELAY = 30
 KEEPALIVE_TIMEOUT = KEEPALIVE_INTERVAL + KEEPALIVE_GRACEDELAY
@@ -1085,7 +1086,9 @@ def get_service(self) -> Tuple[Union[None, bool], str]:
                     'target_service': self.target_service_name,
                 }
                 if not self.internal_target:
-                    self.internal_target = (self.target_service_name == 'INTERNAL')
+                    self.internal_target = (
+                        self.target_service_name == MAGIC_INTERNAL_SERVICE
+                    )
                 self.send_data(data_to_send)
                 _status = True
             elif self.shared.get('selector') == MAGICASK:
@@ -1242,7 +1245,9 @@ def get_service(self) -> Tuple[Union[None, bool], str]:
                     data_to_send['target_service'] = service_name
                     self._full_user_device_account = f"{target_login}@{device_name}:{wab_login}"
                     if not self.internal_target:
-                        self.internal_target = (s[2] == 'INTERNAL')
+                        self.internal_target = (
+                            service_name == MAGIC_INTERNAL_SERVICE
+                        )
                     self.send_data(data_to_send)
                     self.target_service_name = service_name
                     self.target_group = s[0]
@@ -1391,10 +1396,7 @@ def select_target(self) -> Tuple[Any, bool, str]:
         selected_target = None
         target_device = self.shared.get('target_device')
         target_login = self.shared.get('target_login')
-        target_service = (
-            self.target_service_name if self.target_service_name != 'INTERNAL'
-            else 'RDP'
-        )
+        target_service = self.target_service_name
         target_group = self.target_group
 
         Logger().info(f"selected target ==> {target_login} {target_device} {target_service}")
@@ -1837,7 +1839,7 @@ def connect_to_target(self, selected_target) -> Tuple[Union[None, bool], str]:
 
         if _status:
             module = kv.get('proto_dest')
-            if module not in {'RDP', 'VNC', 'INTERNAL'}:
+            if module not in {'RDP', 'VNC'}:
                 module = 'RDP'
             if self.internal_target:
                 module = 'INTERNAL'