HL errors no longer throw exception (#118)

Author: CodeSmell

src/main/java/com/walmartlabs/x12/X12Parser.java

@@ -17,6 +17,7 @@
 package com.walmartlabs.x12;
 
 import com.walmartlabs.x12.exceptions.X12ParserException;
+import com.walmartlabs.x12.util.X12ParsingUtil;
 
 public interface X12Parser<T extends X12Document> {
 

src/main/java/com/walmartlabs/x12/X12ParsingUtil.java

@@ -17,14 +17,15 @@
 package com.walmartlabs.x12.dex.dx894;
 
 import com.walmartlabs.x12.X12Parser;
-import com.walmartlabs.x12.X12ParsingUtil;
 import com.walmartlabs.x12.X12Segment;
+import com.walmartlabs.x12.exceptions.X12ErrorDetail;
 import com.walmartlabs.x12.exceptions.X12ParserException;
 import com.walmartlabs.x12.types.InvoiceType;
 import com.walmartlabs.x12.types.ProductQualifier;
 import com.walmartlabs.x12.types.UnitMeasure;
 import com.walmartlabs.x12.util.ConversionUtil;
 import com.walmartlabs.x12.util.SourceToSegmentUtil;
+import com.walmartlabs.x12.util.X12ParsingUtil;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.util.StringUtils;
@@ -329,7 +330,12 @@ protected void parseApplicationHeader(X12Segment headerSegment, Dex894 dex) {
     }
 
     protected void parseVersion(Dex894 dex) {
-        dex.setVersionNumber(X12ParsingUtil.parseVersion(dex.getVersion()));
+        Integer version = X12ParsingUtil.parseVersion(dex.getVersion());
+        if (version == null) {
+            throw new X12ParserException(new X12ErrorDetail(DefaultDex894Parser.DEX_HEADER_ID, "DXS03", "Invalid version format"));
+        } else {
+            dex.setVersionNumber(version);
+        }
     }
 
     /**

src/main/java/com/walmartlabs/x12/dex/dx894/DefaultDex894Parser.java

@@ -18,7 +18,6 @@
 
 import com.walmartlabs.x12.SegmentIterator;
 import com.walmartlabs.x12.X12Parser;
-import com.walmartlabs.x12.X12ParsingUtil;
 import com.walmartlabs.x12.X12Segment;
 import com.walmartlabs.x12.X12TransactionSet;
 import com.walmartlabs.x12.exceptions.X12ParserException;
@@ -27,6 +26,7 @@
 import com.walmartlabs.x12.standard.txset.UnhandledTransactionSet;
 import com.walmartlabs.x12.util.ConversionUtil;
 import com.walmartlabs.x12.util.SourceToSegmentUtil;
+import com.walmartlabs.x12.util.X12ParsingUtil;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.util.StringUtils;

src/main/java/com/walmartlabs/x12/standard/StandardX12Parser.java

@@ -16,12 +16,12 @@
 
 package com.walmartlabs.x12.standard.txset;
 
-import com.walmartlabs.x12.X12ParsingUtil;
 import com.walmartlabs.x12.X12Segment;
 import com.walmartlabs.x12.X12TransactionSet;
 import com.walmartlabs.x12.exceptions.X12ParserException;
 import com.walmartlabs.x12.standard.X12Group;
 import com.walmartlabs.x12.util.ConversionUtil;
+import com.walmartlabs.x12.util.X12ParsingUtil;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;