Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow querying chrono-node for the built-in casual references - eg morning, evening, night #494

Open
Nantris opened this issue Jan 26, 2023 · 1 comment

Comments

@Nantris
Copy link

Nantris commented Jan 26, 2023

The rationale for this is to make it easier to build refiners - for example I want to make a refiner to imply any reference to "tomorrow" to 12:00pm, but then tomorrow night is set to 12:00pm, even though we're only using imply and not assign

So basically I want to check for "tomorrow night", "tomorrow evening" and so on, and exclude them from the refiner logic - but it would be a lot better to have a complete list provided by the package rather than to write them down myself and hope I got them all (and then ideally check again when the package updates.)

@Nantris
Copy link
Author

Nantris commented Jan 26, 2023

By the way, is "night" no longer a supported casual reference?

I don't see it mentioned here - but I do see "evening" https://github.com/wanasit/chrono/blob/master/src/common/casualReferences.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant