Skip to content
This repository has been archived by the owner on May 2, 2019. It is now read-only.

Player won't start playing if first add files to playlists #6

Open
wangwenx190 opened this issue Dec 4, 2018 · 4 comments
Open

Player won't start playing if first add files to playlists #6

wangwenx190 opened this issue Dec 4, 2018 · 4 comments
Assignees
Labels
bug Something isn't working P0 Blocker bug
Milestone

Comments

@wangwenx190
Copy link
Owner

Describe the bug

If you run this tool for the first time, the player will not start playing even if you have added files to the playlist.

To Reproduce

Add files to the playlist when there is only one empty playlist

Expected behavior

Player plays the first file in the current playlist

Actual behavior

Nothing happens and click the play button is not working as well.

@wangwenx190 wangwenx190 self-assigned this Dec 4, 2018
@wangwenx190 wangwenx190 added bug Something isn't working P0 Blocker bug labels Dec 4, 2018
@wangwenx190 wangwenx190 added this to the 1.0.0 milestone Dec 4, 2018
@wangwenx190
Copy link
Owner Author

Even if there are items in the combobox, currentText() still return an empty QString. Strange. Don't know why.

@wangwenx190
Copy link
Owner Author

Bug located. signal dataRefreshed() emitted too early. May fix another bug at the same time.

@wangwenx190
Copy link
Owner Author

It seems that commit f5d2454 has fixed this issue. Quite ugly code, I admit. But it works anyway. I hope I can make it more beautiful some time later.

@wangwenx190
Copy link
Owner Author

Leave it open for a bit longer, make sure it is actually fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working P0 Blocker bug
Projects
None yet
Development

No branches or pull requests

1 participant