Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this plugin threadsafe? #52

Open
buckett opened this issue Mar 21, 2017 · 2 comments
Open

Is this plugin threadsafe? #52

buckett opened this issue Mar 21, 2017 · 2 comments

Comments

@buckett
Copy link

buckett commented Mar 21, 2017

Currently if you attempt a parallel build with projects that use this plugin you get a warning:

$ mvn -T1C install
[..snipped..]
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Sakai Library:
[WARNING] com.github.warmuuh:libsass-maven-plugin:0.2.6-libsass_3.4.0
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************

Is the plugin threadsafe and just not marked as such, or are there problems running this plugin this way?

@warmuuh
Copy link
Owner

warmuuh commented Mar 22, 2017

i honestly did not look into it... i guess, it is, but did not tested it. i gladly accept any PR, if you want to spend time looking into this.

@fostersdesign
Copy link

I just noticed my Maven build that uses libsass-maven outputs a similar log message as @buckett mentioned above. I'm using 0.2.10-libsass_3.5.3 with Maven 3.6.1.

Here is a Maven page about parallel builds including a plugin checklist for "@threadsafe":
https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3

I personally don't have much experience or expertise with multi-threading, so I'm mentioning this in case someone else does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants