Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compact and expanded outputStyles #84

Open
VsevolodGolovanov opened this issue Sep 16, 2020 · 4 comments
Open

Support compact and expanded outputStyles #84

VsevolodGolovanov opened this issue Sep 16, 2020 · 4 comments

Comments

@VsevolodGolovanov
Copy link
Contributor

Libsass supports them since 3.2.0: https://github.com/sass/libsass/releases/tag/3.2.0

@VsevolodGolovanov
Copy link
Contributor Author

Despite the warning by the plugin:

[WARNING] outputStyle=expanded is replaced by nested. Cause: libsass 3.1 only supports compressed and nested

, looking at the code, it doesn't seem to actually replace the outputStyle itself. So it's probably taking effect as is. Just gotta remove the warning itself, update comments and tests.

@123Haynes
Copy link

@VsevolodGolovanov I don't see any code for that warning, so I assume it's from the upstream jsass lib.

Can you check if the error still exists with my fork? https://gitlab.com/haynes/libsass-maven-plugin
It uses an updated version of jsass.

@VsevolodGolovanov
Copy link
Contributor Author

@123Haynes ,
image

@123Haynes
Copy link

123Haynes commented Sep 29, 2020

@VsevolodGolovanov aaah I missed that. Thanks :) Removing it from my fork now :)

https://gitlab.com/haynes/libsass-maven-plugin/-/merge_requests/65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants