From 20fb7e2a9ed2d2e5133d283765ba32922ad39209 Mon Sep 17 00:00:00 2001
From: Peter Mucha <peter.mucha@adevinta.com>
Date: Fri, 16 Feb 2024 12:20:13 +0100
Subject: [PATCH] added jars as build artifacts

---
 milkman-dist/pom.xml                       | 21 +++++++++++-
 milkman-dist/src/assembly/plugins-jars.xml | 38 ++++++++++++++++++++++
 milkman-plugin.json                        |  6 ----
 3 files changed, 58 insertions(+), 7 deletions(-)
 create mode 100644 milkman-dist/src/assembly/plugins-jars.xml

diff --git a/milkman-dist/pom.xml b/milkman-dist/pom.xml
index 442f95b1..c11cb1cd 100644
--- a/milkman-dist/pom.xml
+++ b/milkman-dist/pom.xml
@@ -380,7 +380,20 @@
 							</descriptors>
 						</configuration>
 					</execution>
-						<execution>
+					<execution>
+						<id>plugin-jars-assembly</id>
+						<phase>package</phase>
+						<goals>
+							<goal>single</goal>
+						</goals>
+						<configuration>
+							<finalName>plugin-jars</finalName>
+							<descriptors>
+								<descriptor>src/assembly/plugins-jars.xml</descriptor>
+							</descriptors>
+						</configuration>
+					</execution>
+					<execution>
 						<id>assembly-cli</id>
 						<phase>package</phase>
 						<goals>
@@ -424,6 +437,12 @@
 								<exclude>${project.artifactId}*.jar</exclude>
 							</excludes>
 						</fileSet>
+						<fileSet>
+							<directory>${project.build.directory}/plugin-jars-bin</directory>
+							<includes>
+								<include>*.jar</include>
+							</includes>
+						</fileSet>
 					</fileSets>
 
 				</configuration>
diff --git a/milkman-dist/src/assembly/plugins-jars.xml b/milkman-dist/src/assembly/plugins-jars.xml
new file mode 100644
index 00000000..f4f48c5a
--- /dev/null
+++ b/milkman-dist/src/assembly/plugins-jars.xml
@@ -0,0 +1,38 @@
+<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
+	<id>bin</id>
+	<formats>
+		<format>dir</format>
+	</formats>
+	<baseDirectory>milkman-jars</baseDirectory>
+	 <includeBaseDirectory>false</includeBaseDirectory>
+	<moduleSets>
+		
+		<moduleSet>
+			<useAllReactorProjects>true</useAllReactorProjects>
+			<includes>
+				<include>com.github.warmuuh:milkman-note</include>
+				<include>com.github.warmuuh:milkman-rest</include>
+				<include>com.github.warmuuh:milkman-scripting</include>
+				<include>com.github.warmuuh:milkman-explore</include>
+				<include>com.github.warmuuh:milkman-jdbc</include>
+				<include>com.github.warmuuh:milkman-sync-git</include>
+				<include>com.github.warmuuh:milkman-privatebin</include>
+				<include>com.github.warmuuh:milkman-graphql</include>
+				<include>com.github.warmuuh:milkman-grpc</include>
+				<include>com.github.warmuuh:milkman-cassandra</include>
+				<include>com.github.warmuuh:milkman-test</include>
+				<include>com.github.warmuuh:milkman-auth</include>
+				<include>com.github.warmuuh:milkman-ws</include>
+				<include>com.github.warmuuh:milkman-sio</include>
+				<include>com.github.warmuuh:milkman-nosql</include>
+			</includes>
+			<binaries>
+				<unpack>false</unpack>
+				<outputFileNameMapping>${module.artifactId}.${module.extension}</outputFileNameMapping>
+				<includeDependencies>false</includeDependencies>
+			</binaries>
+		</moduleSet>
+	</moduleSets>
+</assembly>
diff --git a/milkman-plugin.json b/milkman-plugin.json
index 3c468d14..c534a957 100644
--- a/milkman-plugin.json
+++ b/milkman-plugin.json
@@ -12,12 +12,6 @@
       "artifact": "milkman-cassandra.jar",
       "description": "Introduces Cql Requests to Milkman using cassandra datastax driver."
     },
-    {
-      "author": "warmuuh",
-      "name": "milkman-cli",
-      "artifact": "milkman-cli.jar",
-      "description": "This is an experimental interactive command line interface for plugin. After copying the content of the archive to the root directory of milkman, you can start it by `mm` on terminal."
-    },
     {
       "author": "warmuuh",
       "name": "milkman-explore",