Merge pull request #399 from warrensbox/fix-goreport-issues

Fixing Goreport Issues

Author: MatrixCrawler

lib/download_test.go

@@ -26,7 +26,6 @@ func TestDownloadFromURL_FileNameMatch(t *testing.T) {
 	}
 
 	t.Logf("Current home directory: %q", home)
-	var installLocation = ""
 	if runtime.GOOS != "windows" {
 		installLocation = filepath.Join(home, installPath)
 	} else {

lib/param_parsing/parameters_test.go

@@ -71,8 +71,7 @@ func TestGetParameters_check_config_precedence(t *testing.T) {
 		getopt.CommandLine = getopt.New()
 	})
 	os.Args = []string{"cmd", "--chdir=../../test-data/integration-tests/test_precedence"}
-	parameters := prepare()
-	parameters = GetParameters()
+	parameters := GetParameters()
 	expected := "0.11.3"
 	if parameters.Version != expected {
 		t.Error("Version Param was not as expected. Actual: " + parameters.Version + ", Expected: " + expected)

lib/param_parsing/terraform_version_test.go

@@ -19,6 +19,6 @@ func TestGetParamsFromTerraformVersion_no_file(t *testing.T) {
 	params.ChDirPath = "../../test-data/skip-integration-tests/test_no_file"
 	params, _ = GetParamsFromTerraformVersion(params)
 	if params.Version != "" {
-		t.Errorf("Expected emtpy version string. Got: %v", params.Version)
+		t.Errorf("Expected empty version string. Got: %v", params.Version)
 	}
 }

lib/param_parsing/tfswitch_test.go

@@ -19,6 +19,6 @@ func TestGetParamsFromTfSwitch_no_file(t *testing.T) {
 	params.ChDirPath = "../../test-data/skip-integration-tests/test_no_file"
 	params, _ = GetParamsFromTfSwitch(params)
 	if params.Version != "" {
-		t.Errorf("Expected emtpy version string. Got: %v", params.Version)
+		t.Errorf("Expected empty version string. Got: %v", params.Version)
 	}
 }

lib/param_parsing/toml_test.go

@@ -44,7 +44,7 @@ func TestGetParamsTOML_no_file(t *testing.T) {
 	params.ChDirPath = "../../test-data/skip-integration-tests/test_no_file"
 	params, _ = getParamsTOML(params)
 	if params.Version != "" {
-		t.Errorf("Expected emtpy version string. Got: %v", params.Version)
+		t.Errorf("Expected empty version string. Got: %v", params.Version)
 	}
 }