Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify OtelConfig #40

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

joonas
Copy link
Member

@joonas joonas commented Sep 26, 2024

Feature or Problem

Rather than using pointers to bool, let's just use bool, it cleans up the code a bit while still accomplishing the same end goal.

Since TraceLevel specifically applies to the host / Rust, we don't need it here.

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
@joonas joonas requested a review from a team as a code owner September 26, 2024 21:55
@joonas joonas merged commit f8ed71d into wasmCloud:main Sep 27, 2024
3 checks passed
@joonas joonas deleted the chore/simplify-otel-config branch September 27, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants