Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add wadm.api.{lattice}.status #282

Open
lachieh opened this issue May 14, 2024 · 8 comments
Open

[FEATURE] add wadm.api.{lattice}.status #282

lachieh opened this issue May 14, 2024 · 8 comments
Labels

Comments

@lachieh
Copy link
Contributor

lachieh commented May 14, 2024

It'd be nice to be able to get some information about wadm itself across the API. Specifically, the version would be good so that consumers can adjust behavior based on differences between versions.

Sample response:

{
  "wadm_version": "0.0.0"
}
Copy link

stale bot commented Jul 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Jul 13, 2024
@brooksmtownsend
Copy link
Member

Bumping for now, @lachieh would you mind dropping some very minimal information that you'd expect from this endpoint? It would be great to add just a few things and mark it good-first-issue 😄

What I could think of is mostly:

  1. Version of wadm
  2. Lattices observed (number or list, list of names is more useful but in the thousands it may overflow the NATS message size)
  3. Outstanding commands/events?

@stale stale bot removed the stale label Jul 15, 2024
@lachieh
Copy link
Contributor Author

lachieh commented Jul 15, 2024

Yeah I think those are all valid. My primary use case was the parsing of responses based on the wadm version, but I think those are also great additions. Is there a way to summarize wadm's health? All applications healthy, some pending, errors, etc? That could also be useful here, but not fully necessary. Count is probably fine on the lattices, and outstanding events/commands might be useful as a boolean or a count also.

@lachieh
Copy link
Contributor Author

lachieh commented Jul 15, 2024

I updated the description with a sample response. I think it's probably fine to leave this as just the version for an initial implementation and have the additional fields be subsequent features. If you'd like to add more to the response you should have edit access 👍

@brooksmtownsend
Copy link
Member

brooksmtownsend commented Jul 15, 2024

Is there a way to summarize wadm's health?

Good question. Other than NATS connectivity (which you would know from a response) this feels kinda like it gets into OTEL metrics and failing to ack messages. I don't think wadm has a concept currently of an internal health since it's very work-queue based

Copy link

stale bot commented Sep 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Sep 13, 2024
@lachieh
Copy link
Contributor Author

lachieh commented Sep 17, 2024

still valid

@stale stale bot removed the stale label Sep 17, 2024
Copy link

stale bot commented Nov 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants