fix: update branch offsets before evaluating compiled function frame size (#1699)

* add test case and improve triggering debug assert

* fix issue-1698

the comment describes the underlying issue.

* remove test because of its massive input file size

Author: Robbepop

crates/wasmi/src/engine/executor/stack/values.rs

@@ -374,7 +374,12 @@ impl FrameParams {
 
     /// Zero-initialize the remaining locals and parameters.
     pub fn init_zeroes(mut self) {
-        debug_assert!(self.range.start <= self.range.end);
+        debug_assert!(
+            self.range.start <= self.range.end,
+            "failed to zero-initialize `FrameParams`: start = {:?}, end = {:?}",
+            self.range.start,
+            self.range.end,
+        );
         while !core::ptr::eq(self.range.start, self.range.end) {
             // Safety: We do not write out-of-buffer due to the above condition.
             unsafe { self.init_next(UntypedVal::from(0_u64)) }

crates/wasmi/src/engine/translator/func/mod.rs

@@ -187,10 +187,16 @@ impl WasmTranslator<'_> for FuncTranslator {
         mut self,
         finalize: impl FnOnce(CompiledFuncEntity),
     ) -> Result<Self::Allocations, Error> {
+        // Note: `update_branch_offsets` might change `frame_size` so we need to compute it prior.
+        //
+        // Context:
+        // This only happens if the function has so many instructions that some conditional branch
+        // operators need to be encoded as their fallbacks which requires to allocate more function
+        // local constant values, thus increasing the size of the function frame.
+        self.update_branch_offsets()?;
         let Some(frame_size) = self.frame_size() else {
             return Err(Error::from(TranslationError::AllocatedTooManyRegisters));
         };
-        self.update_branch_offsets()?;
         finalize(CompiledFuncEntity::new(
             frame_size,
             self.instrs.drain(),