Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply: don't allow canceling during activation #20

Open
1 task done
water-sucks opened this issue Jul 30, 2024 · 0 comments
Open
1 task done

apply: don't allow canceling during activation #20

water-sucks opened this issue Jul 30, 2024 · 0 comments
Assignees
@water-sucks
Labels
enhancement New feature or request

Comments

@water-sucks
Copy link
Owner

Feature Description

Canceling an activation with Ctrl+C is bound to cause issues with atomicity of the currently running system.

nixos-rebuild already implements some protection of this using systemd-run, but this itself is not enough. We should also handle SIGTERM signals and force a second Ctrl+C signal before exiting the program.

Help

Yes

Issues

  • I have checked existing issues and there are no existing ones with the same request.
@water-sucks water-sucks added the enhancement New feature or request label Jul 30, 2024
@water-sucks water-sucks self-assigned this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@water-sucks water-sucks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@water-sucks